Defect #23751: Tab buttons appear on pages that have no tabs - Redmine

Actions

Copy link

Defect #23751

closed

Tab buttons appear on pages that have no tabs

Added by Edouard Cunibil almost 9 years ago. Updated almost 9 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Target version:

3.3.1

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

3.3.0

Description

The JS condition that's supposed to hide the tab buttons checks if the first LI element is visible or not.
If there is no LI element, the tab buttons are always shown.

file: public/javascripts/application.js
line: 383

replace:

if ((tabsWidth < el.width() - bw) && (lis.first().is(':visible'))) {

by:

if ((tabsWidth < el.width() - bw) && (lis.length === 0 || lis.first().is(':visible'))) {

In case it helps, here is my environemt:

Environment:
  Redmine version                3.3.0.stable
  Ruby version                   2.1.5-p273 (2014-11-13) [x86_64-linux-gnu]
  Rails version                  4.2.6
  Environment                    production
  Database adapter               Mysql2
SCM:
  Git                            2.1.4
  Filesystem                     
Redmine plugins:
  redmine_agile                  1.4.1
  redmine_backlogs               v1.0.6
  redmine_checklists             3.1.3

Sorry not provinding a patch but I'm a Git guy so I don't have anything related to SVN installed on my system.

Files

Download all files