Project

General

Profile

Actions
Copy link

Defect #23777

closed

Login button is too thin on WebKit browsers

Added by Go MAEDA almost 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
UI
Target version:
-
Resolution:
Fixed
Affected version:

Description

Affected version: trunk (r15595 and later)

Firefox:
No problem.

Chrome:
padding property of input#login-submit seems to be ineffective.

Files

Download all files
login-firefox.png (13.9 KB) login-firefox.png Go MAEDA, 2016-09-07 03:42
login-chrome.png (14 KB) login-chrome.png Go MAEDA, 2016-09-07 03:42
fix-login-button-is-too-thin.diff (1.4 KB) fix-login-button-is-too-thin.diff patch Go MAEDA, 2016-09-07 04:20
fix-login-button-is-too-thin_v2.diff (566 Bytes) fix-login-button-is-too-thin_v2.diff Marius BĂLTEANU, 2016-10-01 14:38
Actions
Copy link
 #1

Updated by Go MAEDA almost 10 years ago

This is a patch to fix this issue: fix-login-button-is-too-thin.diff
Changes input[type="submit"] to button[type="submit"].

Actions
Copy link
 #2

Updated by martin Jacob almost 10 years ago

  • File Plombier Créteil.jpg added
Actions
Copy link
 #3

Updated by Go MAEDA almost 10 years ago

  • File deleted (Plombier Créteil.jpg)
Actions
Copy link
 #4

Updated by Toshi MARUYAMA almost 10 years ago

I cannot see any problem on Windows 10 Chrome 53.0.2785.101 m (64-bit).

Actions
Copy link
 #5

Updated by Go MAEDA almost 10 years ago

Toshi MARUYAMA wrote:

I cannot see any problem on Windows 10 Chrome 53.0.2785.101 m (64-bit).

Thank you for checking on Windows. I tested on Windows after seeing your post and found that the problem can not be reproduced on Windows.

I reproduced this problem on:

  • Mac OS X 10.11.6 - Chrome 52.0.2743.116 (64-bit)
  • Mac OS X 10.11.6 - Safari 9.1.3 (11601.7.8)
Actions
Copy link
 #6

Updated by Go MAEDA almost 10 years ago

  • Target version set to 3.4.0
Actions
Copy link
 #7

Updated by Jean-Philippe Lang almost 10 years ago

  • Status changed from New to Needs feedback

Could we fix the style without having to change the DOM element from input to button?

Actions
Copy link
 #8

Updated by Marius BĂLTEANU almost 10 years ago

Jean-Philippe Lang wrote:

Could we fix the style without having to change the DOM element from input to button?

Attached an alternative patch that fixes this issue only from CSS. I chose to target all input elements with type submit to prevent further issues like this.

Actions
Copy link
 #9

Updated by Jean-Philippe Lang almost 10 years ago

  • Assignee set to Go MAEDA

Thanks for the patch. Go, can you confirm the fix works for you?

Actions
Copy link
 #10

Updated by Go MAEDA almost 10 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Go MAEDA to Jean-Philippe Lang

Jean-Philippe Lang wrote:

Thanks for the patch. Go, can you confirm the fix works for you?

Thanks to Marius BALTEANU, the fix works completely for me.

Actions
Copy link
 #11

Updated by Jean-Philippe Lang almost 10 years ago

  • Status changed from Resolved to Closed
  • Target version deleted (3.4.0)
  • Resolution set to Fixed

Thanks for your feedback, the patch is committed.

Actions
Copy link

Also available in: Atom PDF