Project

General

Profile

Actions

Patch #24062

closed

Allow only vertical reorderingin sortable lists

Added by Vincent Robert almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Here is a patch which allows only vertical reordering for positioned items:

From: Vincent Robert <vincent.robert@nanego.com>
Date: Thu, 13 Oct 2016 12:04:01 +0200
Subject: Vertical reordering only

---
 public/javascripts/application.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/public/javascripts/application.js b/public/javascripts/application.js
index 087d3de..b303702 100644
--- a/public/javascripts/application.js
+++ b/public/javascripts/application.js
@@ -597,6 +597,7 @@ function beforeShowDatePicker(input, inst) {
     }, options );

     return this.sortable($.extend({
+      axis: 'y',
       handle: ".sort-handle",
       helper: function(event, ui){
         ui.children('td').each(function(){
--

Thank you for considering this tiny contribution ;)


Files

patch.diff (727 Bytes) patch.diff Vincent Robert, 2016-10-13 12:12

Related issues

Related to Redmine - Feature #12909: Drag'n'drop order configuration for statuses, trackers, roles...ClosedJean-Philippe Lang

Actions
Actions #1

Updated by Toshi MARUYAMA almost 8 years ago

  • Description updated (diff)
Actions #2

Updated by Toshi MARUYAMA almost 8 years ago

  • Status changed from New to Needs feedback

Please explain more details.

Actions #3

Updated by Vincent Robert almost 8 years ago

Hi Toshi

As we are sorting elements in a column, we should add this constraint. If we don't specify the axis, we can drag the item to the right or to the left, which does not make sense in our case ; it's cleaner to move them vertically only.

Please try to sort elements with and without the "axis" attribute. You will instantly see the difference.

Thank you

Actions #4

Updated by Toshi MARUYAMA almost 8 years ago

  • Related to Feature #12909: Drag'n'drop order configuration for statuses, trackers, roles... added
Actions #5

Updated by Toshi MARUYAMA almost 8 years ago

  • Status changed from Needs feedback to New
  • Target version set to 3.3.2
Actions #6

Updated by Jean-Philippe Lang almost 8 years ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang

Committed, thanks.

Actions #7

Updated by Jean-Philippe Lang almost 8 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF