Project

General

Profile

Actions
Copy link

Defect #24297

closed

Show action not allowed for time entries in closed projects

Added by Felix Schäfer almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Permissions and roles
Target version:
3.2.5
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

It is currently not possible to GET /time_entries/123.xml for closed projects even with the correct permissions.

In the TimelogController currently checks if the time entry is editable for the current user on show, edit and update. This means show doesn't work for closed projects as the time entry is then not editable.

Files

24297.patch (1.09 KB) 24297.patch Felix Schäfer, 2016-11-08 15:10
Actions
Copy link
 #1

Updated by Felix Schäfer almost 9 years ago

The attached patch is a proposal to fix this problem.

Actions
Copy link
 #2

Updated by Jan from Planio www.plan.io almost 9 years ago

  • Status changed from New to Confirmed
  • Target version set to Candidate for next minor release
Actions
Copy link
 #3

Updated by Jean-Philippe Lang almost 9 years ago

  • Status changed from Confirmed to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version changed from Candidate for next minor release to 3.2.5
  • Resolution set to Fixed

Fix committed with a test, thanks.

Actions
Copy link
 #4

Updated by Jean-Philippe Lang almost 9 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF