Defect #24309

Setting page for repository does not scroll horizontally on small screens

Added by Dmitry Lisichkin over 2 years ago. Updated 11 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:UI - Responsive
Target version:3.4.7
Resolution:Fixed Affected version:

Description

Horizontall scroll bar is missed on settings page for repository.
Problem appears after #20632 (because overflow: hidden; on #wrapper)

We can wrap repositories table with .autoscroll ofcouse or even do it in common/_tabs.html.erb
But maybe it would be better to remove overflow: hidden; from #wrapper?
I dont know what is the best way to fix this and want to discuss because this problem may affect many other pages.
I think that turning off horizontal scroll completely is not a good idea.

Similar problems:
#22336
#21808#note-5

scrollbar_missed _-(.png (20.8 KB) Dmitry Lisichkin, 2016-11-09 16:06

displaying_the_scroll_bar_on_settings_page_for_repository.patch Magnifier (2.84 KB) Tomomi Yuzuriha, 2018-07-13 08:02

Related issues

Related to Redmine - Patch #22336: Revision Table does not scroll horizontally on small screens Closed
Related to Redmine - Defect #28523: Display horizontal scroll bar of plugins table when overf... Closed

Associated revisions

Revision 17447
Added by Go MAEDA 11 months ago

Setting page for repository does not scroll horizontally on small screens (#24309).

Patch by Tomomi Yuzuriha.

Revision 17448
Added by Go MAEDA 11 months ago

Merged r17447 from trunk to 3.4-stable (#24309).

History

#1 Updated by Toshi MARUYAMA over 2 years ago

  • Description updated (diff)

#2 Updated by Go MAEDA about 1 year ago

  • Related to Patch #22336: Revision Table does not scroll horizontally on small screens added

#3 Updated by Go MAEDA about 1 year ago

  • Related to Defect #28523: Display horizontal scroll bar of plugins table when overflow occurs on small screen added

#4 Updated by Go MAEDA about 1 year ago

  • Category changed from UI to UI - Responsive
  • Target version set to Candidate for next minor release

#5 Updated by Tomomi Yuzuriha 11 months ago

I felt it was difficult to judge whether deleting "overflow: hidden; on # wrapper" would be fine or not, Because the range of #wrapper is too big.
So, I propose a patch using the same way as #22336 (displaying the scroll bar using .autoscroll).

#6 Updated by Go MAEDA 11 months ago

  • Subject changed from Horizontal scrollbar is missing to Horizontal scrollbar is missing on settings page for repository
  • Target version changed from Candidate for next minor release to 3.4.7

The very similar fixes were already delivered by #22336 and #28523. Setting the target version to 3.4.7.

#7 Updated by Go MAEDA 11 months ago

  • Status changed from New to Resolved

#8 Updated by Go MAEDA 11 months ago

  • Subject changed from Horizontal scrollbar is missing on settings page for repository to Setting page for repository does not scroll horizontally on small screens
  • Status changed from Resolved to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed. Thank you all for reporting and fixing this issue.

Also available in: Atom PDF