Project

General

Profile

Actions
Copy link

Feature #2435

closed

Plugin API to check that a plugin is correctly installed

Added by Eric Davis over 15 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Plugin API
Target version:
-
Start date:
2009-01-03
Due date:
% Done:

0%

Estimated time:
Resolution:
Wont fix

Description

Both Redmine and Engine migrations follow a strict naming convention for plugins. Problem is, depending on the repository script/plugin install might install the plugin to an incorrect directory. This causes several issues including:

  • migrations get named after the wrong plugin
  • Settings get messed up and set incorrectly

I propose adding a check to Redmine::Plugin.register to make sure that the plugin name matches the installation directory.

Example:

# Required to be installed in vendor/plugins/budget_plugin
Redmine::Plugin.register :budget_plugin  

# Requires to be installed in vendor/plugins/embedded
Redmine::Plugin.register :embedded

References:

Actions
Copy link
 #1

Updated by Eric Davis over 15 years ago

  • Category set to Plugin API
  • Assignee set to Eric Davis

I can implement this, I just wanted to see if anyone had any better ideas other than throwing an error if the directory is incorrect.

Actions
Copy link
 #2

Updated by Gerrit Kaiser over 15 years ago

sounds like a good idea. this hit me as well, and the current error message is not exactly clear about things. So a check would be appreciated!

Actions
Copy link
 #3

Updated by Eric Davis over 13 years ago

  • Target version set to Unplanned backlogs
Actions
Copy link
 #4

Updated by Holger Just over 13 years ago

I developed a patch. It is available from the feature branch on http://github.com/meineerde/redmine/tree/2435-check-plugin-name

Eric: Please check if this is enough or if I should extend it somehow.

Actions
Copy link
 #5

Updated by Eric Davis over 13 years ago

  • Assignee deleted (Eric Davis)

I am stepping down from working on Redmine. If someone else is interesting in working on this issue, feel free to reassign it to them.

Eric Davis

Actions
Copy link
 #6

Updated by Jean-Baptiste Barth almost 11 years ago

  • Status changed from New to Closed
  • Resolution set to Wont fix

Closing this, pretty old and some things have already been implemented since then (check on redmine version or plugin dependency for instance). Plus I don't think that enforcing a strict policy on directory name or place is a good idea (and I think Eric didn't either, see this post)

Actions
Copy link
 #7

Updated by Jean-Baptiste Barth almost 11 years ago

  • Target version deleted (Unplanned backlogs)
Actions
Copy link

Also available in: Atom PDF