Patch #24692

Issue destroy : Reassign time issue autocomplete

Added by David Côté-Tremblay 6 months ago. Updated 6 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Issues
Target version:3.4.0

Description

When deleting an issue, you get a form to propose you where to reassign the time entries. This patch provides an autocomplete instead of entering the raw issue ID.

Patch tested and fully working for Redmine 3.3.1-devel

issue-destroy-reassign-time-autocomplete.patch Magnifier (1.34 KB) David Côté-Tremblay, 2016-12-26 16:58

issue-destroy-reassign-time-autocomplete-v2.patch Magnifier - fix: sugget issues only in the same project (1.09 KB) Go MAEDA, 2016-12-30 06:38

Associated revisions

Revision 16165
Added by Jean-Philippe Lang 6 months ago

Issue destroy : Reassign time issue autocomplete (#24692).

Patch by David Côté-Tremblay and Go MAEDA.

History

#1 Updated by David Côté-Tremblay 6 months ago

  • Status changed from New to Resolved

#2 Updated by David Côté-Tremblay 6 months ago

Sorry bad title, supposed to be : "Issue destroy : Reassign time issue autocomplete"

#3 Updated by Go MAEDA 6 months ago

  • Subject changed from Issue destroy : Also reassign descendants spent hours to Issue destroy : Reassign time issue autocomplete
  • Status changed from Resolved to New

#4 Updated by Go MAEDA 6 months ago

  • Status changed from New to Needs feedback

Thank you for submitting the patch.

Reassigning destination issue must be an issue within the same project (please see the code in IssuesController#destroy: source:trunk/app/controllers/issues_controller.rb@15923#L354 ). Therefore the auto completing should not suggest issues in other project.

I am not sure, but I think the key-value pair :scope => Setting.cross_project_subtasks in the arguments of escape_javascript auto_complete_issues_path should be removed.

#5 Updated by Go MAEDA 6 months ago

Go MAEDA wrote:

Reassigning destination issue must be an issue within the same project (please see the code in IssuesController#destroy: source:trunk/app/controllers/issues_controller.rb@15923#L354 ). Therefore the auto completing should not suggest issues in other project.

Fixed. Updated the patch.

#6 Updated by Go MAEDA 6 months ago

  • Target version changed from Candidate for next major release to 3.4.0

#7 Updated by Jean-Philippe Lang 6 months ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed with slight changes. I removed the wrapping span, let me know if it was of any use.

Also available in: Atom PDF