Project

General

Profile

Actions

Defect #24869

closed

Circular inclusion detected when including a wiki page with the same name

Added by Michael Esemplare over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Category:
Wiki
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

A Circular inclusion is incorrectly identified when including a page internal to a project with the same name from another project. This affects version prior to and including 3.3.2. To recreate:

  1. Create test-project-1
  2. Create wiki page named "IncludedPage" with any contents
  3. Create test-project-2
  4. Create wiki page named "IncludedPage"; contents include to test-project-1: {{include(test-project-1:IncludedPage)}}
  5. Create wiki page named "TestPage"; contents include to local IncludedPage: {{include(IncludedPage)}}

In test-project-2/IncludedPage there is no error, however in test-project-2/TestPage the circular inclusion is detected.

Suggest modifying lib/redmine/wiki_formatting/macros.rb to use page.id instead of page.title.


Files

Actions #1

Updated by Michael Esemplare over 7 years ago

  • File 0001-Modify-circular-inclusion-test-to-use-page.id-instea.patch added
Actions #2

Updated by Michael Esemplare over 7 years ago

Incorrect patch previously uploaded. Please remove 0001 and use 0002 instead.

Actions #3

Updated by Go MAEDA over 7 years ago

  • Category set to Wiki
Actions #4

Updated by Go MAEDA over 7 years ago

  • File deleted (0001-Modify-circular-inclusion-test-to-use-page.id-instea.patch)
Actions #5

Updated by Go MAEDA over 7 years ago

Confirmed the problem and the patch works fine as expected.

Actions #6

Updated by Jean-Philippe Lang over 7 years ago

  • Status changed from Confirmed to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Committed, thanks.

Actions #7

Updated by Jean-Philippe Lang over 7 years ago

  • Subject changed from False Positive: Circular Inclusion Detected for include macro to Circular inclusion detected when including a wiki page with the same name
  • Status changed from Resolved to Closed
  • Target version changed from 3.3.3 to 3.2.6
Actions

Also available in: Atom PDF