Project

General

Profile

Actions

Defect #24869

closed

Circular inclusion detected when including a wiki page with the same name

Added by Michael Esemplare over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Category:
Wiki
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

A Circular inclusion is incorrectly identified when including a page internal to a project with the same name from another project. This affects version prior to and including 3.3.2. To recreate:

  1. Create test-project-1
  2. Create wiki page named "IncludedPage" with any contents
  3. Create test-project-2
  4. Create wiki page named "IncludedPage"; contents include to test-project-1: {{include(test-project-1:IncludedPage)}}
  5. Create wiki page named "TestPage"; contents include to local IncludedPage: {{include(IncludedPage)}}

In test-project-2/IncludedPage there is no error, however in test-project-2/TestPage the circular inclusion is detected.

Suggest modifying lib/redmine/wiki_formatting/macros.rb to use page.id instead of page.title.


Files

Actions

Also available in: Atom PDF