Patch #25526
Revert API change in spent_hours field in issue#show
Status: | Closed | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | % Done: | 0% | ||
Category: | REST API | |||
Target version: | 3.2.6 |
Description
When preloading the spent_hours
of issues (as e.g. done for #20661, they default to 0
instead of the previous default 0.0
. This results in a change of the issue#show
API which now also returns an Integer instead of a Float. Previously (in Redmine 3.2), the API used to return the data the following way:
{
"issue": {
"id": 15,
...
"spent_hours": 0.0,
...
}
}
While later versions (including the current trunk) return them as follows:
{
"issue": {
"id": 15,
...
"spent_hours": 0,
...
}
}
This appears to break strict API clients which expect a float there. In our tests, this change appears to break the current Android version of RedminePM, probably due to some internal type exceptions. The attached patch was extracted from Planio and fixes this behavior. With it, we follow the previous behavior of always sending Floats.
Related issues
Associated revisions
Always set spent_hours instance variables to a Float in Issue instances (#25526).
Patch by Holger Just.
Adds a test for #25526.
total_spent_hours not returned in 3.2 (#25526).
History
#1
Updated by Jean-Philippe Lang over 5 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
Patch committed with an API test, thanks.
#2
Updated by Jean-Philippe Lang over 5 years ago
- Related to Patch #20661: Show visible spent time link for users allowed to view time entries. added
#3
Updated by Go MAEDA over 5 years ago
- Target version set to 3.2.6
#4
Updated by Toshi MARUYAMA over 5 years ago
- Description updated (diff)