Project

General

Profile

Actions
Copy link

Patch #26130

closed

Refactor "multiple_values_detail" struct creation

Added by Thomas Löber about 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Code cleanup/refactoring
Target version:
4.0.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Hi,

In the IssuesHelper#details_to_strings method (source:trunk/app/helpers/issues_helper.rb@16387#L373) a new class (Struct) is created each time the method is called:

  multiple_values_detail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)

Although classes are garbage collected in recent Ruby versions, it might be better to use a constant definition outside the method, like:

  MultipleValuesDetail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)

Regards,
Thomas

Actions
Copy link
 #1

Updated by Go MAEDA about 8 years ago

  • Category changed from Performance to Code cleanup/refactoring
Actions
Copy link
 #2

Updated by Go MAEDA about 8 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Jean-Philippe Lang about 8 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version set to 4.0.0

Change committed, thanks.

Actions
Copy link
 #4

Updated by Toshi MARUYAMA about 8 years ago

  • Description updated (diff)
Actions
Copy link
 #5

Updated by Toshi MARUYAMA about 8 years ago

  • Target version changed from 4.0.0 to 4.1.0

I think target version should be version:3.5.0 because there is no 3.5-stable in Subversion.

Actions
Copy link
 #6

Updated by Jean-Philippe Lang about 8 years ago

  • Target version changed from 4.1.0 to 4.0.0
Actions
Copy link

Also available in: Atom PDF