Actions
Patch #26130
closedRefactor "multiple_values_detail" struct creation
Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:
0%
Estimated time:
Description
Hi,
In the IssuesHelper#details_to_strings method (source:trunk/app/helpers/issues_helper.rb@16387#L373) a new class (Struct) is created each time the method is called:
multiple_values_detail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)
Although classes are garbage collected in recent Ruby versions, it might be better to use a constant definition outside the method, like:
MultipleValuesDetail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)
Regards,
Thomas
Updated by Go MAEDA over 7 years ago
- Category changed from Performance to Code cleanup/refactoring
Updated by Jean-Philippe Lang over 7 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Target version set to 4.0.0
Change committed, thanks.
Updated by Toshi MARUYAMA over 7 years ago
- Target version changed from 4.0.0 to 4.1.0
I think target version should be version:3.5.0 because there is no 3.5-stable in Subversion.
Updated by Jean-Philippe Lang over 7 years ago
- Target version changed from 4.1.0 to 4.0.0
Actions