Patch #26522

Repository routing bug when file path starts with (browse|entry|raw|changes|annotate|diff)/

Added by Jens Krämer about 1 year ago. Updated 4 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:SCM
Target version:4.0.0

Description

If the first component of a path in a repository equals one of the strings above, the wrong route gets selected in the case of links without repository_id (as they are generated from wiki source: links to the default repository of a project) and the intended action is mistaken for the repository_id parameter. Attached is a patch to the repository routing test illustrating the issue.

I would suggest to change repository#identifier_param to always return an identifier (see second patch) and remove the repository routes without repository_id (rows 280ff in current config/routes.rb).

repository_routing_test.patch Magnifier - illustrates failure of route for certain path (555 Bytes) Jens Krämer, 2017-07-25 11:42

repository_identifier_param.patch Magnifier - always return a repository identifier (381 Bytes) Jens Krämer, 2017-07-25 11:42

Associated revisions

Revision 17386
Added by Jean-Philippe Lang 4 months ago

Removes repository routes without repository_id (#26522).

History

#1 Updated by Toshi MARUYAMA about 1 year ago

  • Target version set to 4.0.0

#2 Updated by Jean-Philippe Lang 4 months ago

  • Subject changed from repository routing bug when file path starts with (browse|entry|raw|changes|annotate|diff)/ to Repository routing bug when file path starts with (browse|entry|raw|changes|annotate|diff)/
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Routes without repository_id are removed.

Also available in: Atom PDF