Project

General

Profile

Actions

Patch #27663

closed

Same relates relation can be created twice

Added by Gregor Schmidt over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Issues
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

By switching from and to, it is possible to create the same relates relation twice. Within the Redmine UI, those relations look like duplicates.

For all other relationship types it's not allowed to create duplicates, so I assume that this is a bug. Attached you may find a proposed fix. It adds a validation to make sure, that reverse relations are detected. It also orders the from and to IDs to ensure, that even during concurrent access, the duplicates are detected on DB level.


Files

Actions #1

Updated by Go MAEDA over 6 years ago

I confirmed the problem.

sqlite> select * from issue_relations where issue_from_id in (42, 43);
id          issue_from_id  issue_to_id  relation_type  delay
----------  -------------  -----------  -------------  ----------
5           42             43           relates
4           43             42           relates
Actions #2

Updated by Go MAEDA over 6 years ago

  • Target version changed from Candidate for next minor release to 3.3.6

LGTM. Setting target version to 3.3.6.

Actions #3

Updated by Go MAEDA about 6 years ago

  • Status changed from New to Resolved
  • Assignee set to Go MAEDA
Actions #4

Updated by Go MAEDA about 6 years ago

  • Status changed from Resolved to New
  • Assignee deleted (Go MAEDA)

The patch breaks a test.

$ bin/rails test test/functional/issue_relations_controller_test.rb
Run options: --seed 33551

# Running:

...F

Failure:
IssueRelationsControllerTest#test_create_xhr [/Users/maeda/redmines/redmine-trunk/test/functional/issue_relations_controller_test.rb:85]:
Expected: 3
  Actual: 1

bin/rails test test/functional/issue_relations_controller_test.rb:70

........

Finished in 4.495535s, 2.6693 runs/s, 6.6733 assertions/s.
12 runs, 30 assertions, 1 failures, 0 errors, 0 skips
Actions #5

Updated by Go MAEDA about 6 years ago

Fix for the test failure described in #27663#note-4.
issue_from_id is always smaller than issue_to_id after applying the patch.

Index: test/functional/issue_relations_controller_test.rb
===================================================================
--- test/functional/issue_relations_controller_test.rb    (revision 17054)
+++ test/functional/issue_relations_controller_test.rb    (working copy)
@@ -82,8 +82,8 @@
       assert_equal 'text/javascript', response.content_type
     end
     relation = IssueRelation.order('id DESC').first
-    assert_equal 3, relation.issue_from_id
-    assert_equal 1, relation.issue_to_id
+    assert_equal 1, relation.issue_from_id
+    assert_equal 3, relation.issue_to_id

     assert_include 'Bug #1', response.body
   end
Actions #6

Updated by Go MAEDA about 6 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed in the trunk and merged to stable branches. Thank you.

Actions #7

Updated by Gregor Schmidt about 6 years ago

Thanks a lot.

I am very sorry for breaking the test suite. I hope this did not cause too much trouble. I'll make sure to run the whole test suite next time.

Actions

Also available in: Atom PDF