Project

General

Profile

Actions

Defect #28000

closed

Deletion of an LDAP authentication mode may fail silently

Defect #28000: Deletion of an LDAP authentication mode may fail silently

Added by Go MAEDA almost 9 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
LDAP
Target version:
Resolution:
Fixed
Affected version:

Description

Deletion of an LDAP authentication mode fails without any error message if one or more users use it. An error message should be displayed.


Files

Updated by Go MAEDA almost 9 years ago Actions #1

  • Target version set to 4.0.0

Setting target version to 4.0.0.

Updated by Toshi MARUYAMA almost 9 years ago Actions #2

  • Target version deleted (4.0.0)

Could you add test?
source:trunk/test/functional/auth_sources_controller_test.rb#L154

Updated by Go MAEDA almost 9 years ago Actions #3

Added an assertion in the test.

Updated by Toshi MARUYAMA almost 9 years ago Actions #4

You can use raw English text and I think you can use "assert_select_error".
source:trunk/test/functional/auth_sources_controller_test.rb#L142

Updated by Go MAEDA almost 9 years ago Actions #5

Toshi MARUYAMA wrote:

You can use raw English text and I think you can use "assert_select_error".
source:trunk/test/functional/auth_sources_controller_test.rb#L142

Do you think using raw text is better? I think I18n.t is better because we don't have to update the test when the English translation for error_can_not_delete_auth_source is changed. And we cannot use assert_select_error for the page because there isn't "div#errorExplanation".

Updated by Go MAEDA almost 9 years ago Actions #6

Toshi MARUYAMA wrote:

You can use raw English text and I think you can use "assert_select_error".
source:trunk/test/functional/auth_sources_controller_test.rb#L142

I think that checking the flash hash is a common way to test flash notices. Please see 7.7 Testing flash notices on Rails Guides. Also in Redmine, the same way is used. Examples as follows:

  • source:tags/3.4.4/test/functional/timelog_controller_test.rb#L678
  • source:tags/3.4.4/test/functional/timelog_controller_test.rb#L689
  • source:tags/3.4.4/test/functional/my_controller_test.rb#L362

I think that assert_select_error can be used for validation errors brought by ActiveRecord::Errors object but cannot be used for flash hash.

Updated by Toshi MARUYAMA almost 9 years ago Actions #7

Go MAEDA wrote:

Toshi MARUYAMA wrote:

You can use raw English text and I think you can use "assert_select_error".
source:trunk/test/functional/auth_sources_controller_test.rb#L142

Do you think using raw text is better?

Yes. Rails changed behaviour many times. It cannot guarantee test result in the future.

Updated by Jens Krämer almost 9 years ago Actions #8

I agree with Toshi, using the raw text in the assertion is preferable. It simplifies the statement and makes it more obvious what is expected.

Updated by Go MAEDA almost 9 years ago Actions #9

Toshi MARUYAMA and Jens Krämer, thank you for your advice!
I have updated the test to use raw text.

Updated by Go MAEDA almost 9 years ago Actions #10

  • Target version set to 4.0.0

I fixed the patch as advised by Toshi and Jens. Setting target version to 4.0.0 again.

Updated by Go MAEDA over 8 years ago Actions #11

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed.

Actions

Also available in: PDF Atom