Patch #28207

Test improvements for footnotes formatting syntax

Added by Mischa The Evil about 1 month ago. Updated 22 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:


Category:Text formatting
Target version:4.0.0


This originates from #28119#note-2.

  1. We might want to add a simple test (like ApplicationHelperTest#test_footnotes, but than in source:trunk/test/unit/lib/redmine/wiki_formatting/markdown_formatter_test.rb) for markdown footnotes as enabled per #16072.
  2. And while looking at the above, the question of 'how many other textile syntax tests are there remaining, lurking outside of source:/trunk/test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb and what do we want to do with them?' came up...
    • The answer to the first part would be 'several' (among them e.g. ApplicationHelperTest#test_footnotes). My answer to the second part of the question would be 'move them to the dedicated TextileFormatterTest class'.
I'll leave two patches against source:/trunk@17198:
  • 0001-Add-footnotes-test-for-markdown-formatter-16072.patch
    • This patch adds a footnotes test for the markdown formatter (MarkdownFormatterTest#test_footnotes).
  • 0002-Move-textile-footnotes-test-to-TextileFormatterTest.patch
    • This patch moves ApplicationHelperTest#test_footnotes to become TextileFormatterTest#test_footnotes.

In case there is consensus on my answer to the question raised under point 2, I'll open a dedicated container issue for it.

Note: I won't target this issue to any version, as I don't think this is of any use for the changelogs.

0001-Add-footnotes-test-for-markdown-formatter-16072.patch Magnifier (1.31 KB) Mischa The Evil, 2018-02-17 23:56

0002-Move-textile-footnotes-test-to-TextileFormatterTest.patch Magnifier (2.09 KB) Mischa The Evil, 2018-02-17 23:56

Related issues

Related to Redmine - Feature #16072: Markdown footnote support Closed

Associated revisions

Revision 17221
Added by Go MAEDA 22 days ago

Add footnotes test for markdown formatter (#28207).

Patch by Mischa The Evil.

Revision 17222
Added by Go MAEDA 22 days ago

Move textile footnotes test to TextileFormatterTest (#28207).

Patch by Mischa The Evil.


#1 Updated by Mischa The Evil about 1 month ago

#2 Updated by Go MAEDA 22 days ago

  • Target version set to 4.0.0

#3 Updated by Go MAEDA 22 days ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed. Thank you for improving the test suite.

Also available in: Atom PDF