Defect #28322
Commit messages referencing issues should stop at line breaks
Status: | New | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | - | % Done: | 0% | |
Category: | SCM | |||
Target version: | Candidate for next minor release | |||
Resolution: | Affected version: |
Description
When referencing an issue via commit message, the matching should stop at line breaks. Otherwise, unexpected things may happen.
E.g given the following commit message:
Initial version of Feature #123 Includes the following changes: #124 some UI fixes #125 still work in progress
the current implementation will mark #125
as fixed. I think, this is unexpected.
I've attached a patch, which replaces all \s
with [[:blank:]]
in the relevant regular expressions. Those matchers are equivalent, but [[:blank:]]
does not match \r\n
. I've also added a test.
This bug was identified by Holger Just from Planio.
History
#1
Updated by Jan from Planio www.plan.io almost 3 years ago
- Target version set to Candidate for next minor release
#2
Updated by Go MAEDA almost 3 years ago
Thank you for detecting and fixing this issue, it looks good to me.
But I am afraid that some people make use of the current behavior, like the following example.
Refs: #1, #2, #3