Project

General

Profile

Actions

Defect #28469

closed

Syntax highlighter does not work if language name is single-quoted

Added by Go MAEDA almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Text formatting
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Please see the screenshot below. Syntax highlighter does not work if "Text formatting" is set to "Textile" and the language name is enclosed by single quotation marks. The Textile formatter should accept single quotation marks as well as double quotation marks.


Files

screenshot@2x.png (22.7 KB) screenshot@2x.png Go MAEDA, 2018-03-30 09:00
add-single-quoted.patch (695 Bytes) add-single-quoted.patch Mizuki ISHIKAWA, 2018-04-16 01:57
add-single-quoted-2.patch (1.54 KB) add-single-quoted-2.patch Mizuki ISHIKAWA, 2018-04-24 06:50

Related issues

Has duplicate Redmine - Defect #14443: Property class in <code> inside <pre> does not accept a single quotesClosed

Actions
Actions #1

Updated by Mizuki ISHIKAWA almost 6 years ago

I think it is natural to use single quotes.
I wrote a patch to fix this defect.

Actions #2

Updated by Marius BÄ‚LTEANU almost 6 years ago

Mizuki ISHIKAWA wrote:

I think it is natural to use single quotes.
I wrote a patch to fix this defect.

I would recommend to add a tests for this single quotes case.

Actions #3

Updated by Mizuki ISHIKAWA almost 6 years ago

Marius BALTEANU wrote:

Mizuki ISHIKAWA wrote:

I think it is natural to use single quotes.
I wrote a patch to fix this defect.

I would recommend to add a tests for this single quotes case.

I forgot to write a test.
I appreciate your advice.

This is the patch that added the test.

Actions #4

Updated by Go MAEDA almost 6 years ago

  • Target version set to 3.3.8

LGTM. Setting target version to 3.3.8.

Actions #5

Updated by Go MAEDA almost 6 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed to the trunk and stable branches. Thank you for fixing this issue.

Actions #6

Updated by Go MAEDA over 5 years ago

  • Has duplicate Defect #14443: Property class in <code> inside <pre> does not accept a single quotes added
Actions

Also available in: Atom PDF