Project

General

Profile

Actions

Defect #28576

closed

Attachments are added even if validation fails when updating an issue via email

Added by Doruk Fişek almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Email receiving
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Setting: There's an issue that a required field's empty.

When I try to update the issue via e-mail (but not add value to the required field), Redmine rejects the e-mail update (as it should).

However if the e-mail has an attachment, it adds the attachment to the issue nevertheless.

What it should do is to reject the attachment also.


Files

28576.patch (1.51 KB) 28576.patch Takenori TAKAKI, 2018-10-04 04:03
Actions #1

Updated by Go MAEDA over 5 years ago

  • Category set to Email receiving
Actions #2

Updated by Takenori TAKAKI over 5 years ago

I found the cause of this problem in MailHandler#receive_issue_reply.
I made a patch and attach it.

Actions #3

Updated by Go MAEDA over 5 years ago

  • Target version set to 3.3.9

Setting the target version to 3.3.9.

Actions #4

Updated by Go MAEDA over 5 years ago

  • Subject changed from Redmine rejects e-mail but adds the attachment to Attachments are added even if validation fails when updating an issue via email
  • Status changed from New to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you all for reporting and fixing the issue.

Actions #5

Updated by Go MAEDA over 5 years ago

  • Status changed from Resolved to Closed

Merged to stable branches.

Actions

Also available in: Atom PDF