Defect #28576
Attachments are added even if validation fails when updating an issue via email
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | Email receiving | |||
| Target version: | 3.3.9 | |||
| Resolution: | Fixed | Affected version: |
Description
Setting: There's an issue that a required field's empty.
When I try to update the issue via e-mail (but not add value to the required field), Redmine rejects the e-mail update (as it should).
However if the e-mail has an attachment, it adds the attachment to the issue nevertheless.
What it should do is to reject the attachment also.
28576.patch 
(1.51 KB)
Associated revisions
Fix: Attachments are added even if validation fails when updating an issue via email (#28576).
Patch by Takenori TAKAKI.
History
#1
Updated by Go MAEDA over 4 years ago
- Category set to Email receiving
#2
Updated by Takenori TAKAKI over 4 years ago
- File 28576.patch added
I found the cause of this problem in MailHandler#receive_issue_reply.
I made a patch and attach it.
#3
Updated by Go MAEDA over 4 years ago
- Target version set to 3.3.9
Setting the target version to 3.3.9.
#4
Updated by Go MAEDA about 4 years ago
- Subject changed from Redmine rejects e-mail but adds the attachment to Attachments are added even if validation fails when updating an issue via email
- Status changed from New to Resolved
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you all for reporting and fixing the issue.
#5
Updated by Go MAEDA about 4 years ago
- Status changed from Resolved to Closed
Merged to stable branches.