Patch #28662

Replace "Cancel" buttons from the modals with "Cancel" link

Added by Marius BALTEANU 7 months ago. Updated 10 days ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:4.1.0

Description

In the current UI, the main action for a form is represented by a button element (eg: Create, Create and continue, Add, etc) and the "Cancel" action is represented by a link. This is a very useful because the main action should be more evident for an user.

In the modals (Export to CSV, Add watchers, Add members), both actions (main and cancel) are represented by a button and this is confusing. The attached patch replaces all the cancel buttons from the modals with the same "Cancel" link used in the rest of the app.

current.png (35.8 KB) Marius BALTEANU, 2018-04-30 11:08

after.png (36.1 KB) Marius BALTEANU, 2018-04-30 11:08

0001-Replace-cancel-button-with-cancel-link-in-modals.patch Magnifier (6.33 KB) Marius BALTEANU, 2018-11-10 08:42

History

#1 Updated by Marius BALTEANU 7 months ago

Current UI:

After applying this patch:

#2 Updated by Go MAEDA 6 months ago

  • Target version set to 4.1.0

#3 Updated by Go MAEDA 21 days ago

  • File patch-29848-v2.patch added

Updated the patch for the current trunk (r17612).

$ patch -p1 < 0001-replace-Cancel-button-in-the-modals-with-a-Cancel-li.patch
patching file app/views/groups/_new_users_modal.html.erb
patching file app/views/issue_categories/_new_modal.html.erb
patching file app/views/issues/index.html.erb
Hunk #1 FAILED at 45.
1 out of 1 hunk FAILED -- saving rejects to file app/views/issues/index.html.erb.rej
patching file app/views/members/_new_modal.html.erb
patching file app/views/principal_memberships/_new_modal.html.erb
patching file app/views/sudo_mode/_new_modal.html.erb
patching file app/views/timelog/index.html.erb
Hunk #1 FAILED at 33.
1 out of 1 hunk FAILED -- saving rejects to file app/views/timelog/index.html.erb.rej
patching file app/views/versions/_new_modal.html.erb
patching file app/views/watchers/_new.html.erb
patching file app/views/wiki/_new_modal.html.erb
Hunk #1 succeeded at 24 (offset 8 lines).

#4 Updated by Marius BALTEANU 20 days ago

Go MAEDA wrote:

Updated the patch for the current trunk (r17612).

[...]

Please note that the updated patch includes some changes that are already committed. Please let me know if you want to update the patch for you.

#5 Updated by Marius BALTEANU 10 days ago

  • File deleted (0001-replace-Cancel-button-in-the-modals-with-a-Cancel-li.patch)

#6 Updated by Marius BALTEANU 10 days ago

  • File deleted (patch-29848-v2.patch)

#7 Updated by Marius BALTEANU 10 days ago

@Go Maeda, I've removed from your updated patch some unnecessary changes.

Also available in: Atom PDF