Project

General

Profile

Actions

Defect #29247

closed

Textile phrase modifiers break wiki macros

Added by Stephan Wenzel almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Text formatting
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

redcloth.rb, Redmine's textile interpreter, has a long standing bug or "glitch". That glitch relates to using modifiers (bold, italic, underline, etc.) together with a macro.

*{{user(1)}}*

will not produce the desired result, namely a link to a user in bold face. Instead, it will produce a "}" in boldface like here: {{}}

I propose the following fix to lib/redmine/wiki_formatting/textile/redcloth3.rb:

346c346,347
<     C_STYL = '(?:\{[^"}]+\})'
---
> #   C_STYL = '(?:\{[^"}]+\})' 
>     C_STYL = '(?:\{[^{][^"}]+\})' 

The proposed fix will catch double curly brackets and still apply styles (boldface, underline, italic, etc.)


Files

29247.patch (1.12 KB) 29247.patch Added a test to Stephan Wenzel's patch Go MAEDA, 2018-07-19 02:48
Actions

Also available in: Atom PDF