Wrong use of refute_includes in tests
|Assignee:||Go MAEDA||% Done:|
refute_includes assertion expects the
collection first and the
object to test for after. The test in source:/trunk/test/functional/queries_controller_test.rb@17558#L627 uses the
collection form though.
It seems most of Redmine tests use source:/trunk/test/test_helper.rb@17558#L205
assert_not_include which expects the
collection form. The following patch corrects this problem:
--- a/test/functional/queries_controller_test.rb +++ b/test/functional/queries_controller_test.rb @@ -645,7 +645,7 @@ class QueriesControllerTest < Redmine::ControllerTest # response includes systemwide visible version assert_include ["OnlineStore - Systemwide visible version", "7", "open"], json # response doesn't include non visible version - refute_includes ["Private child of eCookbook - Private Version of public subproject", "6", "open"], json + assert_not_include ["Private child of eCookbook - Private Version of public subproject", "6", "open"], json end def test_subproject_filter_time_entries_with_project_id_should_return_filter_values
#1 Updated by Mizuki ISHIKAWA 15 days ago
That makes sense to me.
refute_includes json, ["Private child of eCookbook - Private Version of public subproject", "6", "open"]
Although the test works with the above code, refute_includes is only used in redmine at three places.
assert_not_include is more familiar.