Defect #29990

Add missing fixtures for test_create_should_send_notification

Added by Marius BALTEANU 4 months ago. Updated 4 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:4.0.0
Resolution:Fixed Affected version:

Description

The bellow test fails when it is run in isolation

Failure:
CommentTest#test_create_should_send_notification [/builds/marius-balteanu/redmine/test/unit/comment_test.rb:39]:
"ActionMailer::Base.deliveries.size" didn't change by 2.
Expected: 2
  Actual: 1

bin/rails test test/unit/comment_test.rb:35

Attached a patch that adds the missing fixtures.

add_missing_fixtures.patch Magnifier (562 Bytes) Marius BALTEANU, 2018-11-17 19:44


Related issues

Copied to Redmine - Defect #30054: Add missing fixtures for test_create_with_one_attachment Closed

Associated revisions

Revision 17648
Added by Go MAEDA 4 months ago

Add missing fixtures for test_create_should_send_notification (#29990).

Patch by Marius BALTEANU.

History

#1 Updated by Marius BALTEANU 4 months ago

  • Subject changed from Add missing fixtures for test test_create_should_send_notification to Add missing fixtures for test_create_should_send_notification

#2 Updated by Marius BALTEANU 4 months ago

  • Description updated (diff)

#3 Updated by Marius BALTEANU 4 months ago

  • File add_missing_fixtures_to_documents.patch added

And one more for test/functional/documents_controller_test.rb

root@45ec3a6558b0:/work# ruby test/functional/documents_controller_test.rb 
DEPRECATION WARNING: `secrets.secret_token` is deprecated in favor of `secret_key_base` and will be removed in Rails 6.0. (called from <top (required)> at /work/config/environment.rb:14)
Run options: --seed 39471

# Running:

...........F

Failure:
DocumentsControllerTest#test_create_with_one_attachment [test/functional/documents_controller_test.rb:135]:
Expected: 2
  Actual: 1

bin/rails test test/functional/documents_controller_test.rb:109

...

Finished in 1.231643s, 12.1788 runs/s, 34.9127 assertions/s.
15 runs, 43 assertions, 1 failures, 0 errors, 0 skips

#4 Updated by Go MAEDA 4 months ago

  • Status changed from New to Confirmed
  • Target version set to 4.1.0

#5 Updated by Go MAEDA 4 months ago

  • Copied to Defect #30054: Add missing fixtures for test_create_with_one_attachment added

#6 Updated by Go MAEDA 4 months ago

Marius BALTEANU wrote:

And one more for test/functional/documents_controller_test.rb

[...]

I have created another issue #30054.

#7 Updated by Go MAEDA 4 months ago

  • File deleted (add_missing_fixtures_to_documents.patch)

#8 Updated by Go MAEDA 4 months ago

  • Category set to Code cleanup/refactoring
  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Target version changed from 4.1.0 to 4.0.0
  • Resolution set to Fixed

Committed. Thank you for your daily contribution.

Also available in: Atom PDF