Project

General

Profile

Actions

Defect #30259

closed

URLs end with "-" are rendered incorrectly in Textile

Added by Hirofumi Kadoya over 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Text formatting
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Last character "-" makes wrong link
please add link "-" character

for example googledrive use "-"
--

ja---

概要、説明、注記等で、URLリンクの最後の文字が "-"だった場合
リンク扱いとならず、誤ったリンクとなる
グーグルドライブなどは、最終文字が "-" となることがあり、修正してほしいです

画像も参照してください


Files

Actions #1

Updated by Go MAEDA over 5 years ago

  • Subject changed from Last character "-" makes wrong link to URLs end with "-" are rendered incorrectly in Textile
  • Description updated (diff)
  • Category set to Text formatting
  • Status changed from New to Confirmed

confirmed the problem. This issue is reproducible in Textile. Markdown is not affected.

Input:

http://example.com/foo-

Expected output:

<a class="external" href="http://example.com/foo-">http://example.com/foo-</a>

Actual output:

<a class="external" href="http://example.com/foo">http://example.com/foo</a>-

Actions #3

Updated by Go MAEDA about 5 years ago

  • Target version set to Candidate for next minor release
Actions #4

Updated by Guillermo ML about 5 years ago

Same with ?, &, # and $ characters. These URL:

https://example.org/ticket.form.php?id=333?
https://example.org/ticket.form.php?id=333&
https://example.org/TicketID=455#
https://example.org/TicketID=455$

will be rendered (3.4.4.stable) as:

For example the second link could be generated by glpi tool and the third one is sometimes generated by otrs tool. I think all four are valid characters at the end of an URL.

Actions #5

Updated by Go MAEDA about 5 years ago

  • Target version changed from Candidate for next minor release to 4.0.2

Setting the target version to 4.0.2.

Actions #6

Updated by Go MAEDA about 5 years ago

  • Target version changed from 4.0.2 to 4.1.0
Actions #7

Updated by Go MAEDA about 5 years ago

  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you all for reporting and fixing this issue.

Actions

Also available in: Atom PDF