Project

General

Profile

Actions

Patch #30827

closed

git tags can't handle utf-8

Added by Pavel Rosický about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
SCM
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

1/ create a git tag that contains ascii incompatible character like "Aufräumen"
2/ open the repository page

Internal Server Error - incompatible character encodings: UTF-8 and ASCII-8BIT
https://github.com/redmine/redmine/blob/979b0b6331db287179661594e22539331c1d8fb3/app/views/repositories/_navigation.html.erb#L35


Files

git_adapter.rb.patch (488 Bytes) git_adapter.rb.patch Pavel Rosický, 2019-02-18 10:03
git_adapter.rb.patch (1.2 KB) git_adapter.rb.patch v2 Pavel Rosický, 2019-02-18 18:22
git_tests.patch (2.45 KB) git_tests.patch Pavel Rosický, 2019-02-18 18:22
git_repository.tar.gz (20.5 KB) git_repository.tar.gz test/fixtures/repositories Pavel Rosický, 2019-02-18 18:48

Related issues

Related to Redmine - Defect #16881: Git: repository page crashes when non-ascii character in tag or branch nameClosedToshi MARUYAMA

Actions
Actions #1

Updated by Go MAEDA about 5 years ago

  • Related to Defect #16881: Git: repository page crashes when non-ascii character in tag or branch name added
Actions #2

Updated by Go MAEDA about 5 years ago

Maybe also branches should be fixed?

Actions #3

Updated by Pavel Rosický about 5 years ago

right, thanks. I'm looking into it!

Actions #4

Updated by Pavel Rosický about 5 years ago

@Go MAEDA you can simulate the problem with attached tests.

I'm not sure about the input encoding, AFAIK it should be set by the shell's LC_ALL variable or is it always in UTF-8?

Actions #5

Updated by Pavel Rosický about 5 years ago

looks like I can't attach .tar.gz as a patch...

Actions #6

Updated by Go MAEDA about 5 years ago

  • Target version set to Candidate for next major release
Actions #8

Updated by Go MAEDA almost 5 years ago

  • Status changed from Resolved to Closed
  • Target version deleted (Candidate for next major release)

Fixed for upcoming Redmine 4.1.0 (#16881).

Actions

Also available in: Atom PDF