Patch #30827

git tags can't handle utf-8

Added by Pavel Rosický 3 months ago. Updated 27 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:-

Description

1/ create a git tag that contains ascii incompatible character like "Aufräumen"
2/ open the repository page

Internal Server Error - incompatible character encodings: UTF-8 and ASCII-8BIT
https://github.com/redmine/redmine/blob/979b0b6331db287179661594e22539331c1d8fb3/app/views/repositories/_navigation.html.erb#L35

git_adapter.rb.patch Magnifier (488 Bytes) Pavel Rosický, 2019-02-18 10:03

git_adapter.rb.patch Magnifier - v2 (1.2 KB) Pavel Rosický, 2019-02-18 18:22

git_tests.patch Magnifier (2.45 KB) Pavel Rosický, 2019-02-18 18:22

git_repository.tar.gz - test/fixtures/repositories (20.5 KB) Pavel Rosický, 2019-02-18 18:48


Related issues

Related to Redmine - Defect #16881: Git: repository page crashes when non-ascii character in ... Closed

History

#1 Updated by Go MAEDA 3 months ago

  • Related to Defect #16881: Git: repository page crashes when non-ascii character in tag or branch name added

#2 Updated by Go MAEDA 3 months ago

Maybe also branches should be fixed?

#3 Updated by Pavel Rosický 3 months ago

right, thanks. I'm looking into it!

#4 Updated by Pavel Rosický 3 months ago

@Go MAEDA you can simulate the problem with attached tests.

I'm not sure about the input encoding, AFAIK it should be set by the shell's LC_ALL variable or is it always in UTF-8?

#5 Updated by Pavel Rosický 3 months ago

looks like I can't attach .tar.gz as a patch...

#6 Updated by Go MAEDA 3 months ago

  • Target version set to Candidate for next major release

#8 Updated by Go MAEDA 27 days ago

  • Status changed from Resolved to Closed
  • Target version deleted (Candidate for next major release)

Fixed for upcoming Redmine 4.1.0 (#16881).

Also available in: Atom PDF