Project

General

Profile

Actions

Patch #31385

open

Formating toolbar : new color tools

Added by Jérôme BATAILLE almost 5 years ago. Updated over 4 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
UI
Start date:
Due date:
% Done:

0%

Estimated time:

Description

This patch provides 2 new tools with a new color palette to change sélection color :
  • text color
  • background color

Files

RM_31385_formating_toolbar_color_tools_SVN.diff (4.3 KB) RM_31385_formating_toolbar_color_tools_SVN.diff Jérôme BATAILLE, 2019-05-18 14:49
bt_bgcolor.png (429 Bytes) bt_bgcolor.png Jérôme BATAILLE, 2019-05-18 14:49
bt_color.png (699 Bytes) bt_color.png Jérôme BATAILLE, 2019-05-18 14:49
text_color_and_background.png (8.75 KB) text_color_and_background.png Jérôme BATAILLE, 2019-05-18 15:06
text_color.png (14.8 KB) text_color.png Jérôme BATAILLE, 2019-05-18 15:06
RM_31385_formating_toolbar_color_tools_SVN.diff (6.25 KB) RM_31385_formating_toolbar_color_tools_SVN.diff Jérôme BATAILLE, 2019-05-21 01:33
RM_31385_formating_toolbar_color_tools_SVN.diff (6.81 KB) RM_31385_formating_toolbar_color_tools_SVN.diff Jérôme BATAILLE, 2019-05-21 23:53
RM_31385_formating_toolbar_color_tools2_SVN.diff (8.36 KB) RM_31385_formating_toolbar_color_tools2_SVN.diff Jérôme BATAILLE, 2019-05-24 03:08
RM_31385_formating_toolbar_color_tools_jstoolbar_SVN.diff (4.44 KB) RM_31385_formating_toolbar_color_tools_jstoolbar_SVN.diff Jérôme BATAILLE, 2019-09-16 16:48
Actions #1

Updated by Jérôme BATAILLE almost 5 years ago

The correct issue title should : Formating toolbar : new color tools

Actions #2

Updated by Go MAEDA almost 5 years ago

  • Subject changed from Wiki formating tous : new color tools to Formating toolbar : new color tools
Actions #3

Updated by Jérôme BATAILLE almost 5 years ago

Here is the patch, and the 2 new images to put in public/images/jstoolbar/

This patch does not manage the case when we want background an text color at the same time.

Actions #5

Updated by Jérôme BATAILLE almost 5 years ago

Here is a new patch managing some mixed cases of color / background color.

Detects if selected text already contains a css tag.
  • If tag contains the css we want, replace the color.
  • If not, add the css to the other tags.
Actions #6

Updated by Jérôme BATAILLE almost 5 years ago

Fixed previous patch.

Managed more mixed color / background color tags.

@Go thanks to have renamed the issue subject

Actions #7

Updated by Go MAEDA almost 5 years ago

The patch seems supports only Textile but Markdown. Since Redmine supports both Textile and Markdown, I think the patch should also support Markdown.

Actions #8

Updated by Jérôme BATAILLE almost 5 years ago

Hi, I am going to provide the patch for <span style color="green">Markdown</span>

Now that Textile is OK.

Actions #9

Updated by Jérôme BATAILLE over 4 years ago

Hi, here is a patch to apply after the previous patch.
It includes code refactoring and Markdown support.
For Markdown, html filter must be disabled (C.f. http://www.redmine.org/boards/2/topics/56096?r=57052#message-57052).

One remark about responsive design, the tools icons div has no horizontal scrollbar enabled. Thus some icons on the right can disappear with smaller window size.

Actions #10

Updated by Go MAEDA over 4 years ago

  • Target version set to Candidate for next major release
Actions #11

Updated by Jérôme BATAILLE over 4 years ago

Thanks Go to have proposed this for the next major release.

Actions #12

Updated by Dmitry Makurin over 4 years ago

Two latest patches don't work without:

Index: public/javascripts/jstoolbar/jstoolbar.js
===================================================================
--- public/javascripts/jstoolbar/jstoolbar.js    (date 1568621686000)
+++ public/javascripts/jstoolbar/jstoolbar.js    (date 1568636186385)
@@ -373,12 +373,12 @@
         }

         if (typeof(fn) == 'function') {
-            res = (sel) ? fn.call(this,sel) : fn('');
+            res = (sel) ? fn.call(this,sel,prefix,suffix) : fn('');
         } else {
             res = (sel) ? sel : '';
         }

-        subst = prefix + res + suffix;
+        subst = res;

         if (typeof(document["selection"]) != "undefined") {
             document.selection.createRange().text = subst;

Am I missing something? That change have never been mentioned in any of related patches.

Actions #13

Updated by Jérôme BATAILLE over 4 years ago

Hello, you're right changes to jstoolbar.js were missing.

Here is the full SVN diff for this file.

Actions

Also available in: Atom PDF