Project

General

Profile

Actions

Patch #31391

closed

Small refactorization of avatar methods

Added by Marius BĂLTEANU almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Small refactorization of avatar methods:
  • move existing methods from ApplicationHelper to a new helper file (AvatarsHelper)
  • change default avatar size from 50 to 24 because most of the avatars are using the size 24
  • class 'gravatar' is always added and all custom classes are appended
  • added user name as default title for avatar images
  • added two new methods: assignee_avatar and author_avatar
This patch will change 2 existing behaviours:
  • in issue#show page, the titles for assignee and author will have the format: Assignee: <user name> and Author: <user name>
  • the default title of all avatar is now <user name>

The implementation could be improved more, but it is enough for now.

Any feedback is welcome!


Files


Related issues

Blocks Redmine - Patch #5899: Display user's gravatar when editing profileClosedGo MAEDA2010-07-18

Actions
Actions

Also available in: Atom PDF