Defect #32471

Layout of the custom field edit page is different between the single edit page and the batch edit page

Added by Shingo Hosotani almost 3 years ago. Updated over 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Issues
Target version:4.2.0
Resolution:Fixed Affected version:

Description

If you select and edit multiple issues, the custom fields are arranged vertically.
On the other hand, if you select and edit one issue, the custom field is divided into left and right.

single editing:

multiple editing(Before fix):

Applying this patch will cause the custom field to be split into left and right for multiple edits in Issue.

multiple editing(After fix):

The attached patch implements this feature.

split_custom_field_for_bulk_edit.diff Magnifier (1.25 KB) Shingo Hosotani, 2019-11-14 10:20

bulk_edit_after_fix.png (48.4 KB) Shingo Hosotani, 2019-11-14 10:20

single_edit.png (45.6 KB) Shingo Hosotani, 2019-11-14 10:20

bulk_edit_before_fix.png (49.2 KB) Shingo Hosotani, 2019-11-14 10:20

single-edit-layout@2x.png (31.2 KB) Go MAEDA, 2020-03-31 11:54

bulk-edit-layout@2x.png (41 KB) Go MAEDA, 2020-03-31 11:54

0003-Show-toolbar-for-full-width-custom-fields-with-text-.patch Magnifier (1.83 KB) Marius BALTEANU, 2020-04-05 10:45

0002-Unify-css-classes-for-custom-fields-in-issue-show-is.patch Magnifier (3.62 KB) Marius BALTEANU, 2020-04-05 10:45

0001-Use-same-layout-for-custom-fields-in-issue-bulk-edit.patch Magnifier (2.05 KB) Marius BALTEANU, 2020-04-05 10:45

Related issues

Blocks Redmine - Feature #33256: Show wiki toolbar for spent time custom fields with text ... Closed
Blocks Redmine - Defect #33255: Issue auto complete doesn't work for custom fields with t... Closed

Associated revisions

Revision 19689
Added by Go MAEDA over 2 years ago

Use the same layout for custom fields in issue bulk edit page (#32471).

Patch by Shingo Hosotani and Marius BALTEANU.

Revision 19690
Added by Go MAEDA over 2 years ago

Unify CSS classes for custom fields in issue#show, issue#edit and issue#bulk_edit (#32471).

Patch by Marius BALTEANU.

Revision 19691
Added by Go MAEDA over 2 years ago

Show toolbar for full width custom fields with text formatting enabled on issues bulk edit page (#32471).

Patch by Marius BALTEANU.

History

#1 Updated by Go MAEDA almost 3 years ago

  • Category set to Issues
  • Target version set to Candidate for next major release

The patch changes the logic for rendering custom fields in bulk edit page to be the same as in app/views/issues/_form_custom_fields.html.erb.

I think it improves consistency.

#2 Updated by Shingo Hosotani almost 3 years ago

It is just as you say.
Modify app/views/issues/bulk_edit.html.erb and app/views/issues/_form_custom_fields.html.erb to reduce duplication.

#3 Updated by Go MAEDA over 2 years ago

  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

#4 Updated by Go MAEDA over 2 years ago

I think full-width custom fields need to be considered in the bulk edit page.

Editing a single issue:

Bulk edit:

#5 Updated by Marius BALTEANU over 2 years ago

  • Assignee set to Marius BALTEANU

#6 Updated by Marius BALTEANU over 2 years ago

I've attached 3 patches that fix the problem reported here and also, adds the JS toolbar in this page for full width custom fields with text formatting enabled. Should some fixes made here backported to minor versions?

#7 Updated by Marius BALTEANU over 2 years ago

  • Assignee deleted (Marius BALTEANU)

#8 Updated by Marius BALTEANU over 2 years ago

  • Related to Defect #33255: Issue auto complete doesn't work for custom fields with text formatting enabled on issue bulk edit page added

#9 Updated by Marius BALTEANU over 2 years ago

  • Tracker changed from Patch to Defect

#10 Updated by Go MAEDA over 2 years ago

  • Blocks Feature #33256: Show wiki toolbar for spent time custom fields with text formatting enabled added

#11 Updated by Marius BALTEANU over 2 years ago

  • Related to deleted (Defect #33255: Issue auto complete doesn't work for custom fields with text formatting enabled on issue bulk edit page )

#12 Updated by Marius BALTEANU over 2 years ago

  • Blocks Defect #33255: Issue auto complete doesn't work for custom fields with text formatting enabled on issue bulk edit page added

#13 Updated by Go MAEDA over 2 years ago

  • Subject changed from Custom field edit page is different for single selection and multiple selection to Layout of the custom field edit page is different between the single edit screen and the batch edit screen
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch series. Thank you.

#14 Updated by Go MAEDA over 2 years ago

  • Subject changed from Layout of the custom field edit page is different between the single edit screen and the batch edit screen to Layout of the custom field edit page is different between the single edit page and the batch edit page

Also available in: Atom PDF