Project

General

Profile

Actions
Copy link

Defect #32471

closed

Layout of the custom field edit page is different between the single edit page and the batch edit page

Added by Shingo Hosotani over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Issues
Target version:
4.2.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

If you select and edit multiple issues, the custom fields are arranged vertically.
On the other hand, if you select and edit one issue, the custom field is divided into left and right.

single editing:

multiple editing(Before fix):

Applying this patch will cause the custom field to be split into left and right for multiple edits in Issue.

multiple editing(After fix):

The attached patch implements this feature.

Files

Download all files
split_custom_field_for_bulk_edit.diff (1.25 KB) split_custom_field_for_bulk_edit.diff Shingo Hosotani, 2019-11-14 10:20
bulk_edit_after_fix.png (48.4 KB) bulk_edit_after_fix.png Shingo Hosotani, 2019-11-14 10:20
single_edit.png (45.6 KB) single_edit.png Shingo Hosotani, 2019-11-14 10:20
bulk_edit_before_fix.png (49.2 KB) bulk_edit_before_fix.png Shingo Hosotani, 2019-11-14 10:20
single-edit-layout@2x.png (31.2 KB) single-edit-layout@2x.png Go MAEDA, 2020-03-31 11:54
bulk-edit-layout@2x.png (41 KB) bulk-edit-layout@2x.png Go MAEDA, 2020-03-31 11:54
0003-Show-toolbar-for-full-width-custom-fields-with-text-.patch (1.83 KB) 0003-Show-toolbar-for-full-width-custom-fields-with-text-.patch Marius BĂLTEANU, 2020-04-05 10:45
0002-Unify-css-classes-for-custom-fields-in-issue-show-is.patch (3.62 KB) 0002-Unify-css-classes-for-custom-fields-in-issue-show-is.patch Marius BĂLTEANU, 2020-04-05 10:45
0001-Use-same-layout-for-custom-fields-in-issue-bulk-edit.patch (2.05 KB) 0001-Use-same-layout-for-custom-fields-in-issue-bulk-edit.patch Marius BĂLTEANU, 2020-04-05 10:45

Related issues

Blocks Redmine - Feature #33256: Show wiki toolbar for spent time custom fields with text formatting enabledClosedGo MAEDA

Actions
Blocks Redmine - Defect #33255: Issue auto complete doesn't work for custom fields with text formatting enabled on issue bulk edit page ClosedGo MAEDA

Actions
Actions
Copy link
 #1

Updated by Go MAEDA over 5 years ago

  • Category set to Issues
  • Target version set to Candidate for next major release

The patch changes the logic for rendering custom fields in bulk edit page to be the same as in app/views/issues/_form_custom_fields.html.erb.

I think it improves consistency.

Actions
Copy link
 #2

Updated by Shingo Hosotani over 5 years ago

It is just as you say.
Modify app/views/issues/bulk_edit.html.erb and app/views/issues/_form_custom_fields.html.erb to reduce duplication.

Actions
Copy link
 #3

Updated by Go MAEDA over 5 years ago

  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

Actions
Copy link
 #4

Updated by Go MAEDA over 5 years ago

I think full-width custom fields need to be considered in the bulk edit page.

Editing a single issue:

Bulk edit:

Actions
Copy link
 #5

Updated by Marius BĂLTEANU over 5 years ago

  • Assignee set to Marius BĂLTEANU
Actions
Copy link
 #6

Updated by Marius BĂLTEANU over 5 years ago

I've attached 3 patches that fix the problem reported here and also, adds the JS toolbar in this page for full width custom fields with text formatting enabled. Should some fixes made here backported to minor versions?

Actions
Copy link
 #7

Updated by Marius BĂLTEANU over 5 years ago

  • Assignee deleted (Marius BĂLTEANU)
Actions
Copy link
 #8

Updated by Marius BĂLTEANU over 5 years ago

  • Related to Defect #33255: Issue auto complete doesn't work for custom fields with text formatting enabled on issue bulk edit page added
Actions
Copy link
 #9

Updated by Marius BĂLTEANU over 5 years ago

  • Tracker changed from Patch to Defect
Actions
Copy link
 #10

Updated by Go MAEDA over 5 years ago

  • Blocks Feature #33256: Show wiki toolbar for spent time custom fields with text formatting enabled added
Actions
Copy link
 #11

Updated by Marius BĂLTEANU over 5 years ago

  • Related to deleted (Defect #33255: Issue auto complete doesn't work for custom fields with text formatting enabled on issue bulk edit page )
Actions
Copy link
 #12

Updated by Marius BĂLTEANU over 5 years ago

  • Blocks Defect #33255: Issue auto complete doesn't work for custom fields with text formatting enabled on issue bulk edit page added
Actions
Copy link
 #13

Updated by Go MAEDA over 5 years ago

  • Subject changed from Custom field edit page is different for single selection and multiple selection to Layout of the custom field edit page is different between the single edit screen and the batch edit screen
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch series. Thank you.

Actions
Copy link
 #14

Updated by Go MAEDA over 5 years ago

  • Subject changed from Layout of the custom field edit page is different between the single edit screen and the batch edit screen to Layout of the custom field edit page is different between the single edit page and the batch edit page
Actions
Copy link

Also available in: Atom PDF