Project

General

Profile

Actions

Defect #32471

closed

Layout of the custom field edit page is different between the single edit page and the batch edit page

Added by Shingo Hosotani over 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Issues
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

If you select and edit multiple issues, the custom fields are arranged vertically.
On the other hand, if you select and edit one issue, the custom field is divided into left and right.

single editing:

multiple editing(Before fix):

Applying this patch will cause the custom field to be split into left and right for multiple edits in Issue.

multiple editing(After fix):

The attached patch implements this feature.


Files


Related issues

Blocks Redmine - Feature #33256: Show wiki toolbar for spent time custom fields with text formatting enabledClosedGo MAEDA

Actions
Blocks Redmine - Defect #33255: Issue auto complete doesn't work for custom fields with text formatting enabled on issue bulk edit page ClosedGo MAEDA

Actions
Actions #1

Updated by Go MAEDA over 4 years ago

  • Category set to Issues
  • Target version set to Candidate for next major release

The patch changes the logic for rendering custom fields in bulk edit page to be the same as in app/views/issues/_form_custom_fields.html.erb.

I think it improves consistency.

Actions #2

Updated by Shingo Hosotani over 4 years ago

It is just as you say.
Modify app/views/issues/bulk_edit.html.erb and app/views/issues/_form_custom_fields.html.erb to reduce duplication.

Actions #3

Updated by Go MAEDA over 4 years ago

  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

Actions #4

Updated by Go MAEDA almost 4 years ago

I think full-width custom fields need to be considered in the bulk edit page.

Editing a single issue:

Bulk edit:

Actions #5

Updated by Marius BĂLTEANU almost 4 years ago

  • Assignee set to Marius BĂLTEANU
Actions #6

Updated by Marius BĂLTEANU almost 4 years ago

I've attached 3 patches that fix the problem reported here and also, adds the JS toolbar in this page for full width custom fields with text formatting enabled. Should some fixes made here backported to minor versions?

Actions #7

Updated by Marius BĂLTEANU almost 4 years ago

  • Assignee deleted (Marius BĂLTEANU)
Actions #8

Updated by Marius BĂLTEANU almost 4 years ago

  • Related to Defect #33255: Issue auto complete doesn't work for custom fields with text formatting enabled on issue bulk edit page added
Actions #9

Updated by Marius BĂLTEANU almost 4 years ago

  • Tracker changed from Patch to Defect
Actions #10

Updated by Go MAEDA almost 4 years ago

  • Blocks Feature #33256: Show wiki toolbar for spent time custom fields with text formatting enabled added
Actions #11

Updated by Marius BĂLTEANU almost 4 years ago

  • Related to deleted (Defect #33255: Issue auto complete doesn't work for custom fields with text formatting enabled on issue bulk edit page )
Actions #12

Updated by Marius BĂLTEANU almost 4 years ago

  • Blocks Defect #33255: Issue auto complete doesn't work for custom fields with text formatting enabled on issue bulk edit page added
Actions #13

Updated by Go MAEDA almost 4 years ago

  • Subject changed from Custom field edit page is different for single selection and multiple selection to Layout of the custom field edit page is different between the single edit screen and the batch edit screen
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch series. Thank you.

Actions #14

Updated by Go MAEDA almost 4 years ago

  • Subject changed from Layout of the custom field edit page is different between the single edit screen and the batch edit screen to Layout of the custom field edit page is different between the single edit page and the batch edit page
Actions

Also available in: Atom PDF