Defect #32860

Invalid links to versions with sharing in project tree

Added by Alexander Meindl 12 months ago. Updated 3 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Roadmap
Target version:4.2.0
Resolution:Fixed Affected version:4.1.0

Description

If a version uses sharing in project tree, there are invalid links in the roadmap overview.

The problem occurs, if the version is in a sub-directory and in the project root. Than there are missing permissions to issues (e.g. if issue module is disabled or current user has no rights to see issues in root project).

The attached patch fixes this problem. The patch is for trunk, but the problem is also available in 4.0.x and 4.1.x.

fix_link_to_version.patch Magnifier (721 Bytes) Alexander Meindl, 2020-01-24 16:32

new_test_and_fix.patch Magnifier (1.78 KB) Alexander Meindl, 2020-01-25 09:36

32860-confirmed.png (182 KB) Go MAEDA, 2020-06-25 16:29

32860-v2.patch Magnifier (2.11 KB) Go MAEDA, 2020-07-04 03:30

Associated revisions

Revision 20149
Added by Go MAEDA 3 months ago

Invalid links to versions with sharing in project tree (#32860).

Patch by Alexander Meindl.

History

#1 Updated by Marius BALTEANU 12 months ago

Thanks for the patch. Can you add a test case for this scenario?

#2 Updated by Alexander Meindl 12 months ago

Here is a test for this patch. This patch also correct link to shared version with hierarchy. Without this patch, version link uses the root project for hierarchy versions - which is not correct imho. Versions with hierarchy should use link to current project.

I hope this test is sufficient. Let me know, if more information is required.

#3 Updated by Go MAEDA 7 months ago

Confirmed the issue.

In the screenshot below, the link "1 issue" and "1 open" point to it parent project (ecookbook"). If "Issue tracking" module is disabled in "ecookbook" project, 403 error page is displayed when you click either of the two links.

#4 Updated by Go MAEDA 7 months ago

  • File 32860-v2.patchMagnifier added
  • Target version set to Candidate for next major release

Combined fix_link_to_version.patch and attach:new_test_and_fix.patch, and update it for the current trunk (r19851).

#5 Updated by Go MAEDA 4 months ago

  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

#6 Updated by Go MAEDA 3 months ago

  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix. Thank you.

Also available in: Atom PDF