Defect #33381

Possible double includes in issue query in gantt helper

Added by Felix Schäfer over 1 year ago. Updated 5 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Gantt
Target version:5.0.0
Resolution:Fixed Affected version:3.4.0

Description

The following include line source:/tags/3.4.0/lib/redmine/helpers/gantt.rb#L141 should not be needed anymore as per r16221. It will not cause any problems currently, but should for example the sort options include any of the included relations, this might lead to ambiguous names in the JOIN statement/double JOIN statements leading to an error in the sorting.

This affects all versions since 3.4.0

33381.patch Magnifier (527 Bytes) Go MAEDA, 2020-06-22 08:14


Related issues

Related to Redmine - Patch #24865: Load associations of query results more efficiently Closed

Associated revisions

Revision 21028
Added by Go MAEDA 5 months ago

Possible double includes in issue query in gantt helper (#33381).

Contributed by Felix Schäfer.

History

#1 Updated by Go MAEDA over 1 year ago

  • Target version set to Candidate for next minor release

#2 Updated by Go MAEDA over 1 year ago

#3 Updated by Go MAEDA 5 months ago

  • Related to Patch #24865: Load associations of query results more efficiently added

#4 Updated by Go MAEDA 5 months ago

  • Target version changed from Candidate for next minor release to 5.0.0

Setting the target version to 5.0.0.

#5 Updated by Go MAEDA 5 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix. Thank you.

Also available in: Atom PDF