Feature #33425

Auto complete wiki macros

Added by Go MAEDA 5 months ago. Updated 10 days ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:Candidate for next major release
Resolution:

Description

The attached patch adds an auto-complete feature for wiki macros. The patch can be applied after updating Tribute with the patch #33424.

The macros are useful, however, those are a bit long to type by hand. And it is also hard for some people to remember. I think these inconveniences can be eliminated by supporting auto-complete for wiki macros.

macro-auto-complete.png (26.2 KB) Go MAEDA, 2020-05-10 09:09

33425.patch Magnifier (2.47 KB) Go MAEDA, 2020-05-11 04:23

33425-v2.patch Magnifier (1.85 KB) Mizuki ISHIKAWA, 2020-06-10 07:50

33425_v3.patch Magnifier (3.12 KB) Mizuki ISHIKAWA, 2020-08-05 06:38

33425_v4.patch Magnifier (2.73 KB) Marius BALTEANU, 2020-10-12 00:10


Related issues

Related to Redmine - Feature #30986: New toolbar button to insert wiki macros New
Related to Redmine - Feature #33820: Auto Complete wiki page links New
Related to Redmine - Feature #31989: Inline issue auto complete (#) in fields with text-format... Closed
Blocked by Redmine - Patch #33424: Update Tribute to 5.1.3 Closed

History

#1 Updated by Go MAEDA 5 months ago

#2 Updated by Go MAEDA 5 months ago

  • Related to Feature #30986: New toolbar button to insert wiki macros added

#3 Updated by Go MAEDA 5 months ago

Sorry, I forgot to attach a patch.

#4 Updated by Go MAEDA 5 months ago

  • Target version set to Candidate for next major release

#5 Updated by Go MAEDA 5 months ago

  • Target version changed from Candidate for next major release to 4.2.0

Let's include this feature in 4.2.0.

#6 Updated by Mizuki ISHIKAWA 4 months ago

I Fixed so that macro completion does not work in the search form in the upper right.

#7 Updated by Marius BALTEANU 4 months ago

  • Assignee set to Marius BALTEANU

#8 Updated by Mizuki ISHIKAWA 3 months ago

With 33425_v2.patch, there was a problem that tribute would be re-initialized even if it was already initialized.
Fix to initialize only when `element.dataset.tribute != 'true'`.

#9 Updated by Marius BALTEANU 10 days ago

  • File 33425_v4.patchMagnifier added
  • Assignee deleted (Marius BALTEANU)
  • Target version changed from 4.2.0 to Candidate for next major release

We should use collection to add a new trigger, please see an example attached.

The patch is still not ready because the concern raised by Bernhard and Jean-Philippe in #30986#note-7 is still available and I agree with them, we need a method to describe the macros and how to use them.

#10 Updated by Marius BALTEANU 10 days ago

Another limitation of the patch in the current state is the hardcoded macros values which makes very hard for plugin developers that add new macros to add them to the auto complete as well.

#11 Updated by Marius BALTEANU 9 days ago

#12 Updated by Marius BALTEANU 9 days ago

  • Related to Feature #31989: Inline issue auto complete (#) in fields with text-formatting enabled added

Also available in: Atom PDF