Defect #33426

Error messages for Wiki macros are not internationalized

Added by Go MAEDA over 2 years ago. Updated almost 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:I18n
Target version:4.2.0
Resolution:Fixed Affected version:

Description

Error messages of Wiki macros are always displayed in English regardless of the current user's language setting. In the screenshot below, the user's language is Japanese.

en-error-message-on-ja-page.png (21.8 KB) Go MAEDA, 2020-05-10 10:03

33426.patch Magnifier (5.39 KB) Go MAEDA, 2020-05-10 15:29

fix-r20013.patch Magnifier (35.7 KB) Go MAEDA, 2020-09-10 12:02

Associated revisions

Revision 20013
Added by Go MAEDA almost 2 years ago

Internationalize error messages for wiki macros (#33426).

Patch by Go MAEDA.

Revision 20014
Added by Go MAEDA almost 2 years ago

Update locales (#33426).

Revision 20015
Added by Go MAEDA almost 2 years ago

Don't internationalize error messages used when defining a macro (#33426).

History

#1 Updated by Go MAEDA over 2 years ago

  • File 33426.patchMagnifier added
  • Target version set to Candidate for next major release

Here is a patch to fix the issue.

#2 Updated by Go MAEDA over 2 years ago

  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

#3 Updated by Go MAEDA almost 2 years ago

  • Subject changed from Error messages of Wiki macros are not internationalized to Error messages for Wiki macros are not internationalized
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch.

#4 Updated by Go MAEDA almost 2 years ago

Error messages in macro method that is used when making a macro should not be internationalized for the following reasons:

  • Macros are defined during the startup process of Redmine. At that point, I18n strings are not available yet
  • The error messages appear only in logs, not UI

The attached patch partially reverts the change.

#5 Updated by Go MAEDA almost 2 years ago

  • Status changed from Reopened to Closed

Go MAEDA wrote:

Error messages in macro method that is used when making a macro should not be internationalized for the following reasons:

  • Macros are defined during the startup process of Redmine. At that point, I18n strings are not available yet
  • The error messages appear only in logs, not UI

The attached patch partially reverts the change.

Fixed in r20015.

Also available in: Atom PDF