Project

General

Profile

Actions
Copy link

Defect #33426

closed

Error messages for Wiki macros are not internationalized

Added by Go MAEDA over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
I18n
Target version:
4.2.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Error messages of Wiki macros are always displayed in English regardless of the current user's language setting. In the screenshot below, the user's language is Japanese.

Files

Download all files
en-error-message-on-ja-page.png (21.8 KB) en-error-message-on-ja-page.png Go MAEDA, 2020-05-10 10:03
33426.patch (5.39 KB) 33426.patch Go MAEDA, 2020-05-10 15:29
fix-r20013.patch (35.7 KB) fix-r20013.patch Go MAEDA, 2020-09-10 12:02

Related issues

Related to Redmine - Patch #37668: Fix bad I18n `t` call in macro error handlerClosedGo MAEDA

Actions
Actions
Copy link
 #1

Updated by Go MAEDA over 3 years ago

Here is a patch to fix the issue.

Actions
Copy link
 #2

Updated by Go MAEDA over 3 years ago

  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

Actions
Copy link
 #3

Updated by Go MAEDA about 3 years ago

  • Subject changed from Error messages of Wiki macros are not internationalized to Error messages for Wiki macros are not internationalized
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch.

Actions
Copy link
 #4

Updated by Go MAEDA about 3 years ago

Error messages in macro method that is used when making a macro should not be internationalized for the following reasons:

  • Macros are defined during the startup process of Redmine. At that point, I18n strings are not available yet
  • The error messages appear only in logs, not UI

The attached patch partially reverts the change.

Actions
Copy link
 #5

Updated by Go MAEDA about 3 years ago

  • Status changed from Reopened to Closed

Go MAEDA wrote:

Error messages in macro method that is used when making a macro should not be internationalized for the following reasons:

  • Macros are defined during the startup process of Redmine. At that point, I18n strings are not available yet
  • The error messages appear only in logs, not UI

The attached patch partially reverts the change.

Fixed in r20015.

Actions
Copy link
 #6

Updated by Go MAEDA about 1 year ago

  • Related to Patch #37668: Fix bad I18n `t` call in macro error handler added
Actions
Copy link

Also available in: Atom PDF