Project

General

Profile

Actions

Patch #37668

closed

Fix bad I18n `t` call in macro error handler

Added by Jens Krämer over 1 year ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

this patch adds the missing module reference to the call to `t` in the error handler that is intended to output an error message when a macro failed to render.


Files


Related issues

Related to Redmine - Defect #33426: Error messages for Wiki macros are not internationalizedClosedGo MAEDA

Actions
Actions #1

Updated by Go MAEDA over 1 year ago

  • Related to Defect #33426: Error messages for Wiki macros are not internationalized added
Actions #2

Updated by Go MAEDA over 1 year ago

  • Category set to Code cleanup/refactoring
  • Target version set to 5.1.0

Setting the target version to 5.1.0.

Actions #3

Updated by Mischa The Evil over 1 year ago

It might be good to add some test coverage for this case (and by extension for the change(s) made for #33426) to prevent this from accidentally breaking again.

Actions #4

Updated by Go MAEDA 6 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the fix in r22331. Thank you.

Actions #5

Updated by Mischa The Evil 6 months ago

  • Subject changed from fix bad I18n `t` call in macro error handler to Fix bad I18n `t` call in macro error handler
Actions

Also available in: Atom PDF