Patch #33453

Add plugin CSS classes to plugin settings views

Added by Mischa The Evil about 1 month ago. Updated 29 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Plugin API
Target version:4.2.0

Description

Extracted from #33339#note-20 by Alexander Meindl with patch:

[...] But it should be a possibility for plugin developers to change css for an individual namespace to the plugin settings (without using deface or Javascript).

If a css class would be added with the plugin name, a plugin developer can change css for the required plugin.

I added a patch for this possible change. It would be very helpful, also for other situations for a Redmine plugin developer.

settings_patch_with_plugin_classes.patch Magnifier - From #33339#note-20, by Alexander Meindl (548 Bytes) Mischa The Evil, 2020-05-16 08:07

test-for-33453.patch Magnifier (829 Bytes) Go MAEDA, 2020-05-30 12:27


Related issues

Related to Redmine - Defect #33339: Broken layout of the preview tab of "Welcome text" settin... Closed

Associated revisions

Revision 19813
Added by Go MAEDA 29 days ago

Add plugin CSS classes to plugin settings views (#33453).

Contributed by Alexander Meindl.

History

#1 Updated by Mischa The Evil about 1 month ago

  • Related to Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left added

#2 Updated by Go MAEDA about 1 month ago

Attaching a test for the patch.

#3 Updated by Go MAEDA about 1 month ago

  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

#4 Updated by Go MAEDA 29 days ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch.

Also available in: Atom PDF