Feature #33592
closed
Include updated_on and passwd_changed_on columns in users API response
0%
Description
Users CSV has updated_on and passwd_changed_on column since r19740. I think it is inconsistent that the values are not included in API response.
Files
Related issues
Updated by Go MAEDA over 4 years ago
- Related to Feature #33347: Include updated_on and passwd_changed_on columns when exporting users to CSV added
Updated by vzvu 3k6k over 4 years ago
I've attached a patch to add these fields to user API, written by @Takenori TAKAKI and me. Tests for these changes will be posted later.
Updated by vzvu 3k6k over 4 years ago
- File 0002-Add_assertions_to_users_api_integration_test.patch 0002-Add_assertions_to_users_api_integration_test.patch added
I've attached a patch to ensure these fields are correctly added.
But I'm afraid that these assertions might be too detailed. For now Redmine::ApiTest::UsersTest doesn't have tests for individual fields except for id and some optional fields.
I wonder if we should add assertions for other fields too, or just drop this test patch to keep test code simple.
Updated by Go MAEDA over 4 years ago
- Target version set to Candidate for next minor release
Updated by Go MAEDA about 4 years ago
- Target version changed from Candidate for next minor release to 4.2.0
Setting the target version to 4.2.0.
Updated by Go MAEDA about 4 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you for your contribution.
Updated by Go MAEDA about 4 years ago
- Related to Defect #33787: Redmine::ApiTest::UsersTest fail if config.time_zone is set added
Updated by Go MAEDA almost 4 years ago
- Subject changed from Include updated_on and passwd_changed_on columns in API response to Include updated_on and passwd_changed_on columns in users API response