Project

General

Profile

Actions

Defect #34032

closed

Project settings tab contains two items with the same id

Added by Ali Hamdan over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Project settings
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

In the project setting tabs the [DOM] have 2 elements with non-unique id #edit_project_1 which are in the _edit.html.erb and _issues.html.erb tab which both of them contains labelled_form_for Herve Harster.
In order to fix it i added

labelled_form_for @project ,:as => "project_issues_tracker" 

in the _issues tab.


Files


Related issues

Related to Redmine - Defect #34982: Cannot change the default version and default assignee under settingsClosedGo MAEDA

Actions
Actions #2

Updated by Go MAEDA about 3 years ago

  • Tracker changed from Patch to Defect
  • Status changed from New to Confirmed
Actions #3

Updated by Go MAEDA about 3 years ago

  • Category changed from Projects to Project settings
Actions #4

Updated by Marius BĂLTEANU about 3 years ago

The change looks good, but I propose to use project_issue_tracking because the form handles settings related to Issue tracking module (attached a patch).

The tests pass: https://gitlab.com/redmine-org/redmine/-/pipelines/263093258

Actions #5

Updated by Go MAEDA about 3 years ago

  • Target version changed from Candidate for next minor release to 4.1.2

Setting the target version to 4.1.2.

Actions #6

Updated by Go MAEDA about 3 years ago

  • Subject changed from Project Settings Tabs contains 2 element same id to Project settings tab contains two items with the same id
  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you.

Actions #7

Updated by Go MAEDA about 3 years ago

  • Status changed from Resolved to Closed
  • Target version changed from 4.1.2 to 4.2.0
Actions #8

Updated by Marius BĂLTEANU almost 3 years ago

  • Related to Defect #34982: Cannot change the default version and default assignee under settings added
Actions

Also available in: Atom PDF