Patch #34119

Fix selenium chrome options so files are downloaded to tmp/downloads in system tests

Added by Jens Krämer 3 months ago. Updated about 1 month ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:4.2.0

Description

as posted in https://github.com/SeleniumHQ/selenium/issues/5292#issuecomment-388810585
changing the hash key from chromeOptions to goog:chromeOptions fixes the issue.

Unfortunately it is unclear to me if we have to retain the old 'chromeOptions'
key for windows support and I have no way to try this out.
https://chromedriver.chromium.org/capabilities also uses the
'goog:' prefix in examples without mentioning any specific platform so I
think it will just work.

0001-fix-chrome-options-key-for-system-tests-and-remove-c.patch Magnifier (2.75 KB) Jens Krämer, 2020-10-16 03:39

34119-v2.diff Magnifier (1.92 KB) Go MAEDA, 2020-12-02 09:47

Associated revisions

Revision 20549
Added by Go MAEDA about 1 month ago

Fix selenium chrome options so files are downloaded to tmp/downloads in system tests (#34119).

Patch by Jens Krämer.

History

#1 Updated by Marius BALTEANU about 1 month ago

  • Target version set to 4.2.0

#2 Updated by Go MAEDA about 1 month ago

Updated the patch for the current trunk.

#3 Updated by Go MAEDA about 1 month ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the fix. Thank you.

Also available in: Atom PDF