Project

General

Profile

Actions
Copy link

Patch #34119

closed

Fix selenium chrome options so files are downloaded to tmp/downloads in system tests

Added by Jens Krämer over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Code cleanup/refactoring
Target version:
4.2.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

as posted in https://github.com/SeleniumHQ/selenium/issues/5292#issuecomment-388810585
changing the hash key from chromeOptions to goog:chromeOptions fixes the issue.

Unfortunately it is unclear to me if we have to retain the old 'chromeOptions'
key for windows support and I have no way to try this out.
https://chromedriver.chromium.org/capabilities also uses the
'goog:' prefix in examples without mentioning any specific platform so I
think it will just work.

Files

Download all files
0001-fix-chrome-options-key-for-system-tests-and-remove-c.patch (2.75 KB) 0001-fix-chrome-options-key-for-system-tests-and-remove-c.patch Jens Krämer, 2020-10-16 03:39
34119-v2.diff (1.92 KB) 34119-v2.diff Go MAEDA, 2020-12-02 09:47
Actions
Copy link
 #1

Updated by Marius BĂLTEANU over 4 years ago

  • Target version set to 4.2.0
Actions
Copy link
 #2

Updated by Go MAEDA over 4 years ago

Updated the patch for the current trunk.

Actions
Copy link
 #3

Updated by Go MAEDA over 4 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the fix. Thank you.

Actions
Copy link

Also available in: Atom PDF