Feature #3413

Exclude attachments from incoming emails based on file name

Added by Marco Tralles over 8 years ago. Updated about 4 years ago.

Status:ClosedStart date:2009-05-25
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Email receiving
Target version:2.4.0
Resolution:Fixed

Description

i use a digital signature in mail.app and if i reply to a issue-mail my answer will be added to the issue, but redmine adds also a smime.p7s file wich is my signature (attachment).
It would be helpful, if redmine learns to ignore s/mime attachments.

smime.png - a lot of smime-files are added to the issue if using the mail-interface (11.1 KB) Marco Tralles, 2009-05-25 16:34

mail_handler_ignore_inline_attachments_patch.diff Magnifier (1.44 KB) Egidijus Zideckas, 2012-11-20 09:46

mail_handler_ignore_inline_attachments_patch.diff Magnifier - v2 (1.25 KB) Egidijus Zideckas, 2012-11-20 09:49


Related issues

Duplicated by Redmine - Defect #12866: attachment from received mails Closed
Duplicated by Redmine - Feature #14998: Exclude some attachment types when receiving issues by email Closed
Duplicated by Redmine - Feature #18568: Ignore certain attachment Closed
Duplicated by Redmine - Defect #20993: auto-importing GPG signature file Closed

Associated revisions

Revision 12167
Added by Jean-Philippe Lang about 4 years ago

Exclude attachments from incoming emails based on file name (#3413).

Revision 12168
Added by Jean-Philippe Lang about 4 years ago

Filling locales (#3413).

History

#1 Updated by Jean-Philippe Lang over 8 years ago

  • Subject changed from digital-signature-attachments to Exclude attachments from incoming emails

#2 Updated by Jean-Philippe Lang over 8 years ago

  • Tracker changed from Defect to Feature

#3 Updated by Jean-Philippe Lang over 8 years ago

  • Subject changed from Exclude attachments from incoming emails to Exclude attachments from incoming emails based on mime type

#4 Updated by Patrick Cummins about 8 years ago

+1 for this.

It seems like a very easy change from looking at the source. Even ignoring files by extension would work.

I'm new to ruby... but I'll try to write a patch if I have time.

#5 Updated by marc maurice over 7 years ago

+1

We have a lot of users sending mails to redmine tickets with included images in html signatures.

Each time we have to delete the attachments manually in the ticket. and each time we delete an attachment a notification is sent.

Some attachments that are not real ones must be ignored. Just looking the file extension is not sufficient.

I'm not an email RFC expert, but Looking in two mail sources :

From a mail source with a real attachment :

------_=_NextPart_001_01CB3E16.D938DEBE
Content-Type: application/msword;
    name="=?iso-8859-1?Q?R=E9union_du_18082010=2Edoc?=" 
Content-Transfer-Encoding: base64
Content-Description: =?iso-8859-1?Q?R=E9union_du_18082010=2Edoc?=
Content-Disposition: attachment;
    filename="=?iso-8859-1?Q?R=E9union_du_18082010=2Edoc?=" 

From a mail source with an included attachment :

------_=_NextPart_002_01CB3D29.23FDF48F
Content-Type: image/gif;
    name="image001.gif" 
Content-Transfer-Encoding: base64
Content-ID: <image001.gif@01CB3D39.E7847940>
Content-Description: image001.gif
Content-Location: image001.gif

In the "real" attachment, there is a "Content-Disposition: attachment;" ligne.

Maybe it's the way to detect real attachments from others ?

#6 Updated by Toshi MARUYAMA over 6 years ago

  • Category set to Attachments

#7 Updated by Egidijus Zideckas about 6 years ago

+1

#8 Updated by Max Albrecht almost 6 years ago

+1
i agree that filtering based on mime makes sense in the long run, but for now a small patch would be appreciated. just a comma-seperated list of extension to ignore, defaulting to the very obvious ones: vcf,p7s and other signatures.

#9 Updated by Terence Mill almost 6 years ago

+1

#10 Updated by Kota Shiratsuka almost 6 years ago

+1

#11 Updated by Etienne Massip almost 6 years ago

  • Category changed from Attachments to Email receiving
  • Target version set to Candidate for next major release

#12 Updated by Terence Mill over 5 years ago

+1

#13 Updated by Anonymous about 5 years ago

+1 for this.
We are in the same case and issues are pollute with a lot of signature attachment.

#14 Updated by Egidijus Zideckas about 5 years ago

Please check this patch which skips inline attachments, mostly signatures.
Patch made to current trunk version.

#15 Updated by Egidijus Zideckas about 5 years ago

Sorry, previous file included patch to .gitignore file :)
This one only includes small patch to mail_handler.rb model.

#16 Updated by Jens Schneider almost 5 years ago

+1

we have the same problem (company logo included in signature)

This feature would be great.

#17 Updated by Robert Hailey over 4 years ago

+1

S/MIME & company logos could be handled with a configurable filename match in the admin/settings/incoming-email panel.

e.g.

smime.p7s
*.vcf
my_company_logo.jpg
spacer.gif

As for filtering out "inline" attachments, I would strongly disagree. Some email clients (like Apple's "Mail" app) automatically make attached images inline.

#18 Updated by Jean-Philippe Lang about 4 years ago

  • Duplicated by Feature #14998: Exclude some attachment types when receiving issues by email added

#19 Updated by Jean-Philippe Lang about 4 years ago

  • Subject changed from Exclude attachments from incoming emails based on mime type to Exclude attachments from incoming emails based on file name
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version changed from Candidate for next major release to 2.4.0
  • Resolution set to Fixed

Robert Hailey wrote:

S/MIME & company logos could be handled with a configurable filename match in the admin/settings/incoming-email panel.

Feature added in r12168, a new setting is added to the application settings.

#20 Updated by Toshi MARUYAMA almost 3 years ago

#21 Updated by Toshi MARUYAMA over 2 years ago

#22 Updated by Toshi MARUYAMA over 2 years ago

#23 Updated by Toshi MARUYAMA about 2 years ago

  • Duplicated by Defect #20993: auto-importing GPG signature file added

Also available in: Atom PDF