Defect #34185

Trackers of subprojects are not displayed in the Issue summary page

Added by Yuichi HARADA 12 months ago. Updated 11 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Issues
Target version:4.2.0
Resolution:Fixed Affected version:

Description

The tracker box in the Issue summary page (projects/:id/issues/report, projects/:id/issues/report/tracker) shows the trackers used only for that project.

I think if "Display subprojects issues on main projects by default" setting is enabled, you should also display trackers that are used only in subprojects.

fixed-34185.patch Magnifier (8.64 KB) Yuichi HARADA, 2020-10-29 07:51

34185-v2.patch Magnifier (8.65 KB) Go MAEDA, 2020-11-16 06:16


Related issues

Related to Redmine - Feature #2529: Extend Issue Summary to include subprojects Closed 2009-01-19
Related to Redmine - Defect #35664: Inconsistencies in rendering of subproject data on Issues... New
Related to Redmine - Feature #35647: Allow the user to properly override Setting.display_subpr... New
Copied from Redmine - Defect #10084: Disabled trackers of subprojects are listed in project ov... Closed

Associated revisions

Revision 20401
Added by Go MAEDA 11 months ago

Trackers of subprojects are not displayed in the Issue summary page (#34185).

Patch by Yuichi HARADA.

History

#1 Updated by Yuichi HARADA 12 months ago

  • Copied from Defect #10084: Disabled trackers of subprojects are listed in project overview added

#2 Updated by Yuichi HARADA 12 months ago

I created a patch like this.

diff --git a/app/controllers/reports_controller.rb b/app/controllers/reports_controller.rb
index b9ee49100..976907242 100644
--- a/app/controllers/reports_controller.rb
+++ b/app/controllers/reports_controller.rb
@@ -22,14 +22,14 @@ class ReportsController < ApplicationController
   before_action :find_project, :authorize, :find_issue_statuses

   def issue_report
-    @trackers = @project.rolled_up_trackers(false).visible
+    with_subprojects = Setting.display_subprojects_issues?
+    @trackers = @project.rolled_up_trackers(with_subprojects).visible
     @versions = @project.shared_versions.sorted
     @priorities = IssuePriority.all.reverse
     @categories = @project.issue_categories
     @assignees = (Setting.issue_group_assignment? ? @project.principals : @project.users).sorted
     @authors = @project.users.sorted
     @subprojects = @project.descendants.visible
-    with_subprojects = Setting.display_subprojects_issues?
     @issues_by_tracker = Issue.by_tracker(@project, with_subprojects)
     @issues_by_version = Issue.by_version(@project, with_subprojects)
     @issues_by_priority = Issue.by_priority(@project, with_subprojects)
@@ -46,7 +46,7 @@ class ReportsController < ApplicationController
     case params[:detail]
     when "tracker" 
       @field = "tracker_id" 
-      @rows = @project.rolled_up_trackers(false).visible
+      @rows = @project.rolled_up_trackers(with_subprojects).visible
       @data = Issue.by_tracker(@project, with_subprojects)
       @report_title = l(:field_tracker)
     when "version" 

#3 Updated by Go MAEDA 12 months ago

  • Related to Feature #2529: Extend Issue Summary to include subprojects added

#4 Updated by Go MAEDA 12 months ago

  • Category changed from Projects to Issues
  • Status changed from New to Confirmed
  • Target version set to Candidate for next major release

Confirmed the issue. The attached patch is a fix for #2529 that delivered in Redmine 4.0.0.

#5 Updated by Go MAEDA 12 months ago

  • File 34185-v2.patch added

I have got rid of RuboCop Rails/DynamicFindBy offense.

#6 Updated by Go MAEDA 11 months ago

  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

#7 Updated by Go MAEDA 11 months ago

  • File deleted (34185-v2.patch)

#8 Updated by Go MAEDA 11 months ago

#9 Updated by Go MAEDA 11 months ago

  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for your contribution.

#10 Updated by Go MAEDA 11 months ago

  • Subject changed from Trackers of subprojects are not listed in the Issue summary page to Trackers of subprojects are not displayed in the Issue summary page

#11 Updated by Mischa The Evil 3 months ago

  • Related to Defect #35664: Inconsistencies in rendering of subproject data on Issues Reports added

#12 Updated by Mischa The Evil 3 months ago

  • Related to Feature #35647: Allow the user to properly override Setting.display_subprojects_issues on Issue Reports if a project has subprojects added

Also available in: Atom PDF