Defect #34580
Custom field labels do not contain class "error" when the field value is invalid
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | UI | |||
| Target version: | 4.2.0 | |||
| Resolution: | Fixed | Affected version: |
Description
When the form contains invalid field values, the class "error" is added only to standard fields. We should add it also to custom fields in order to be able to highlight those fields (#32764).
The attached patch fixes this.
Related issues
Associated revisions
History
#1
Updated by Marius BALTEANU over 1 year ago
All tests pass: https://gitlab.com/redmine-org/redmine/-/pipelines/239464521
#2
Updated by Marius BALTEANU over 1 year ago
- Subject changed from Custom field labels doesn't contain class "error" when the field value is invalid to Custom field labels do not contain class "error" when the field value is invalid
#3
Updated by Go MAEDA over 1 year ago
- Related to Feature #32764: Make form validation errors more obvious for users added
#4
Updated by Go MAEDA over 1 year ago
- Status changed from New to Confirmed
#5
Updated by Go MAEDA over 1 year ago
- Status changed from Confirmed to Closed
- Target version deleted (
Candidate for next major release) - Resolution set to Fixed
Committed as a part of #32764. Thank you.
#6
Updated by Marius BALTEANU over 1 year ago
- Target version set to 4.2.0
We should keep this in Changelog because there were some changes regarding how the validation messages are stored in the object.