Feature #32764

Make form validation errors more obvious for users

Added by Marius BALTEANU 11 months ago. Updated 10 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:UI
Target version:4.2.0
Resolution:Fixed

Description

Currently, the validation errors are shown only on top of the page:

which makes very hard for the user to find those fields with errors, especially when there are multiple fields (how is in the case of an issue).

What do you think if we make those fields with errors more obvious?

validation_errors.png (198 KB) Marius BALTEANU, 2020-01-07 23:19

highlight_fields.png (180 KB) Marius BALTEANU, 2020-01-07 23:25

0001-Highlight-fields-with-validation-error.patch Magnifier (738 Bytes) Marius BALTEANU, 2020-01-27 00:57

Associated revisions

Revision 19495
Added by Go MAEDA 10 months ago

Highlight fields with validation error (#32764).

Patch by Marius BALTEANU.

History

#1 Updated by Marius BALTEANU 11 months ago

  • Description updated (diff)

#2 Updated by Go MAEDA 11 months ago

Marius BALTEANU wrote:

What do you think if we make those fields with errors more obvious?

+1
It is a very common interface. And the issue form tends to have many fields, so Redmine should definitely have this feature.

#3 Updated by Mischa The Evil 11 months ago

Marius BALTEANU wrote:

What do you think if we make those fields with errors more obvious?

I think that would be a nice improvement indeed. Though I'm not sure if the field label should be changed too or if the highlighting of the actual field (border) itself is sufficient. We might want to get some feedback on that as some users may have patched/changed the core in such a way that it has custom field styling which may conflict with such a change (however, such shouldn't block a change like proposed here).

#4 Updated by Marius BALTEANU 10 months ago

Here is the patch.

Mischa The Evil wrote:

I think that would be a nice improvement indeed. Though I'm not sure if the field label should be changed too or if the highlighting of the actual field (border) itself is sufficient. We might want to get some feedback on that as some users may have patched/changed the core in such a way that it has custom field styling which may conflict with such a change (however, such shouldn't block a change like proposed here).

Initially, I tried only the field (border), but because all labels are bold, it wasn't obvious enough for me. Anyway, any option works for me.

#5 Updated by Go MAEDA 10 months ago

  • Target version set to 4.2.0

This is a nice UI improvement!

Setting the target version to 4.2.0.

#6 Updated by Go MAEDA 10 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for improving Redmine.

Also available in: Atom PDF