Defect #34694

Progress bar for a shared version on gantt disappears when the tree is collapsed and then expanded

Added by Yasuhiro Sakuramoto 7 months ago. Updated 28 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Gantt
Target version:4.1.4
Resolution:Fixed Affected version:4.1.1

Description

Example:

1. Initial state.

2. The bar will disappear when collapsing Version1 directly under Project1.

I suspect that the cause is in the following line.
source:/branches/4.1-stable/public/javascripts/gantt.js@19434#L262

initial.png (26.7 KB) Yasuhiro Sakuramoto, 2021-02-07 11:32

collapsed_error.png (21.2 KB) Yasuhiro Sakuramoto, 2021-02-07 11:36

34694.patch Magnifier (3.26 KB) Yuichi HARADA, 2021-02-09 08:45

34694-v2.patch Magnifier (3.28 KB) Yuichi HARADA, 2021-02-15 08:53

Associated revisions

Revision 21115
Added by Go MAEDA about 1 month ago

Progress bar for a shared version on gantt disappears when the tree is collapsed and then expanded (#34694).

Patch by Yuichi HARADA.

Revision 21116
Added by Go MAEDA about 1 month ago

Merged r21115 from trunk to 4.2-stable (#34694).

Revision 21117
Added by Go MAEDA about 1 month ago

Merged r21115 from trunk to 4.1-stable (#34694).

History

#1 Updated by Go MAEDA 7 months ago

  • Status changed from New to Confirmed

I have confirmed the issue. It occurs when a version is shared with subprojects.

Steps to reproduce:

1. Create a shared version in a parent project
2. Set any issue's target version to the shared version in the parent project and its subproject
3. On the gannt, collapse and expand the shared version in the parent project
4. The progress bar for the shared version should appear again after expanding the version but does not

#2 Updated by Yuichi HARADA 7 months ago

Go MAEDA wrote:

I have confirmed the issue. It occurs when a version is shared with subprojects.

Steps to reproduce:

1. Create a shared version in a parent project
2. Set any issue's target version to the shared version in the parent project and its subproject
3. On the gannt, collapse and expand the shared version in the parent project
4. The progress bar for the shared version should appear again after expanding the version but does not

I also confirmed.
When the same shared versions are displayed multiple on Gantt, I can't figure out the target taskbar when collapsing one of these versions. To solve this, the top value at the time of initial display is set in the data-default-top attribute for each display item. This value is used as an attribute of the selector when to execute collapse/expand.
I have attached a patch.

#3 Updated by Yuichi HARADA 7 months ago

Yuichi HARADA wrote:

I also confirmed.
When the same shared versions are displayed multiple on Gantt, I can't figure out the target taskbar when collapsing one of these versions. To solve this, the top value at the time of initial display is set in the data-default-top attribute for each display item. This value is used as an attribute of the selector when to execute collapse/expand.
I have attached a patch.

I could get the number of the current rows, so I remade the patch.

#4 Updated by Go MAEDA 7 months ago

  • Target version set to Candidate for next minor release

#5 Updated by Go MAEDA about 1 month ago

  • Target version changed from Candidate for next minor release to 4.1.4

Setting the target version to 4.1.4.

#6 Updated by Marius BALTEANU about 1 month ago

  • Assignee set to Go MAEDA

#7 Updated by Go MAEDA about 1 month ago

  • Subject changed from Collapse/expand of Gantt chart does not work properly when multiple bars of the same shared version are displayed. to Progress bar for a shared version on gantt disappears when the tree is collapsed and then expanded
  • Status changed from Confirmed to Closed
  • Resolution set to Fixed

Committed the fix. Thank you.

#8 Updated by Yasuhiro Sakuramoto 28 days ago

Thank you.

Also available in: Atom PDF