Patch #35081
Update config/environments/*.rb for Rails 6.1
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | Rails support | |||
| Target version: | 5.0.0 |
Description
The attached patch updates Rails environment files (development.rb, production.rb, and test.rb in config/environments directory) for Rails 6.1.
By updating the files, several useful new features in Rails 6.1 will be available (e.g. request_id in production.log, verbose_query_logs in development.log). Also, by looking at the commented out settings, the user can easily know what settings are available (e.g. config.force_ssl in config/environments/production.rb).
0001-RuboCop-Disable-Style-GlobalStdStream-and-Rails-File.patch 
(949 Bytes)
0002-Update-config-environments-.rb-for-Rails-6.1.patch
(12.5 KB)
0001-RuboCop-Disable-Style-GlobalStdStream-and-Rails-File.patch
(845 Bytes)
0002-Update-config-environments-.rb-for-Rails-6.1.patch
(11.6 KB)
Related issues
Associated revisions
RuboCop: Disable Rails/FilePath and Style/GlobalStdStream (#35081).
Update config/environments/*.rb for Rails 6.1 (#35081).
History
#1
Updated by Go MAEDA about 1 year ago
- Related to Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading added
#2
Updated by Marius BALTEANU about 1 year ago
- Assignee set to Marius BALTEANU
#3
Updated by Marius BALTEANU about 1 year ago
- Assignee deleted (
Marius BALTEANU)
config/environments/production.rb which are already defined in config/application.rb with the same value:
config.log_level = :infoalready defined in source:/trunk/config/application.rb#L77config.i18n.fallbacks = truealready defined in source:/trunk/config/application.rb#L57
Also, even commented, I don't think that we should settings add which are not working in the current context, for example, enabling config.assets.css_compressor = :sass it will break Redmine (at least in my local environment).
#4
Updated by Go MAEDA 6 months ago
- File 0001-RuboCop-Disable-Style-GlobalStdStream-and-Rails-File.patch added
- File 0002-Update-config-environments-.rb-for-Rails-6.1.patch added
Marius BALTEANU wrote:
The patch adds two settings inconfig/environments/production.rbwhich are already defined inconfig/application.rbwith the same value:
config.log_level = :infoalready defined in source:/trunk/config/application.rb#L77config.i18n.fallbacks = truealready defined in source:/trunk/config/application.rb#L57
Fixed.
Also, even commented, I don't think that we should settings add which are not working in the current context, for example, enabling
config.assets.css_compressor = :sassit will break Redmine (at least in my local environment).
I checked through configs in the files and removed config.assets.* in config/environments/development.rb and config/environments/production.rb.
Thank you for reviewing the patch.