Project

General

Profile

Actions

Patch #35081

closed

Update config/environments/*.rb for Rails 6.1

Added by Go MAEDA almost 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails support
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The attached patch updates Rails environment files (development.rb, production.rb, and test.rb in config/environments directory) for Rails 6.1.

By updating the files, several useful new features in Rails 6.1 will be available (e.g. request_id in production.log, verbose_query_logs in development.log). Also, by looking at the commented out settings, the user can easily know what settings are available (e.g. config.force_ssl in config/environments/production.rb).


Files


Related issues

Related to Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadingClosedGo MAEDA

Actions
Actions #1

Updated by Go MAEDA almost 3 years ago

  • Related to Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading added
Actions #2

Updated by Marius BĂLTEANU almost 3 years ago

  • Assignee set to Marius BĂLTEANU
Actions #3

Updated by Marius BĂLTEANU over 2 years ago

  • Assignee deleted (Marius BĂLTEANU)
The patch adds two settings in config/environments/production.rb which are already defined in config/application.rb with the same value:

Also, even commented, I don't think that we should settings add which are not working in the current context, for example, enabling config.assets.css_compressor = :sass it will break Redmine (at least in my local environment).

Actions #4

Updated by Go MAEDA about 2 years ago

Marius BALTEANU wrote:

The patch adds two settings in config/environments/production.rb which are already defined in config/application.rb with the same value:

Fixed.

Also, even commented, I don't think that we should settings add which are not working in the current context, for example, enabling config.assets.css_compressor = :sass it will break Redmine (at least in my local environment).

I checked through configs in the files and removed config.assets.* in config/environments/development.rb and config/environments/production.rb.

Thank you for reviewing the patch.

Actions #5

Updated by Go MAEDA about 2 years ago

  • Target version set to 5.0.0

Setting the target version to 5.0.0.

Actions #6

Updated by Go MAEDA about 2 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patches.

Actions

Also available in: Atom PDF