Patch #35372

Better presentation for 2FA recovery codes

Added by Felix Schäfer 4 months ago. Updated 3 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Accounts / authentication
Target version:4.2.2

Description

The following patch makes the recovery codes a little bigger and avoids using `float` to present them in 2 columns. It also improves how some browsers will copy the list, before some browsers would copy the whole list as a long string of all recovery keys concatenated without spaces between individual keys:

```
XXXX XXXX XXXXXXXX XXXX XXXXXXXX XXXX XXXX…
```

After the change the browser understands the list better and copies it as a newline-separated list of keys:

```
XXXX XXXX XXXX
XXXX XXXX XXXX
XXXX XXXX XXXX
…
```

The new presentation is also more responsive and will reflow correctly on narrow screens.

before.png (24.6 KB) Felix Schäfer, 2021-06-08 11:27

after.png (43.9 KB) Felix Schäfer, 2021-06-08 11:27

35372.patch Magnifier (838 Bytes) Felix Schäfer, 2021-06-08 11:33

Related issues

Related to Redmine - Feature #1237: Add support for two-factor authentication Closed 2008-05-14

Associated revisions

Revision 21032
Added by Go MAEDA 3 months ago

Better presentation for 2FA recovery codes (#35372).

Patch by Felix Schäfer.

Revision 21036
Added by Go MAEDA 3 months ago

Merged r21032 from trunk to 4.2-stable (#35372).

History

#1 Updated by Felix Schäfer 4 months ago

#2 Updated by Go MAEDA 4 months ago

  • Target version set to 5.0.0

Setting the target version to 5.0.0.

#3 Updated by Marius BALTEANU 4 months ago

  • Related to Feature #1237: Add support for two-factor authentication added

#4 Updated by Go MAEDA 3 months ago

  • Category changed from UI to Accounts / authentication
  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you.

#5 Updated by Marius BALTEANU 3 months ago

Go Maeda, do you see any problem if we deliver this in 4.2.2? Being an improvement of a new feature of 4.2.0.

#6 Updated by Go MAEDA 3 months ago

  • Status changed from Closed to Resolved
  • Target version changed from 5.0.0 to 4.2.2

Marius BALTEANU wrote:

Go Maeda, do you see any problem if we deliver this in 4.2.2? Being an improvement of a new feature of 4.2.0.

I didn't backport this fix to 4.2-stable because I thought very few people are currently bothered by the issue, but I think it is OK to include it in 4.2.2.

#7 Updated by Go MAEDA 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF