Project

General

Profile

Actions
Copy link

Patch #35372

closed

Better presentation for 2FA recovery codes

Added by Felix Schäfer about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Accounts / authentication
Target version:
4.2.2
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The following patch makes the recovery codes a little bigger and avoids using `float` to present them in 2 columns. It also improves how some browsers will copy the list, before some browsers would copy the whole list as a long string of all recovery keys concatenated without spaces between individual keys:

```
XXXX XXXX XXXXXXXX XXXX XXXXXXXX XXXX XXXX…
```

After the change the browser understands the list better and copies it as a newline-separated list of keys:

```
XXXX XXXX XXXX
XXXX XXXX XXXX
XXXX XXXX XXXX
…
```

The new presentation is also more responsive and will reflow correctly on narrow screens.

Files

Download all files
before.png (24.6 KB) before.png Felix Schäfer, 2021-06-08 11:27
after.png (43.9 KB) after.png Felix Schäfer, 2021-06-08 11:27
35372.patch (838 Bytes) 35372.patch Felix Schäfer, 2021-06-08 11:33

Related issues

Related to Redmine - Feature #1237: Add support for two-factor authenticationClosedGo MAEDA2008-05-14

Actions
Actions
Copy link
 #1

Updated by Felix Schäfer about 4 years ago

Actions
Copy link
 #2

Updated by Go MAEDA about 4 years ago

  • Target version set to 5.0.0

Setting the target version to 5.0.0.

Actions
Copy link
 #3

Updated by Marius BĂLTEANU about 4 years ago

  • Related to Feature #1237: Add support for two-factor authentication added
Actions
Copy link
 #4

Updated by Go MAEDA about 4 years ago

  • Category changed from UI to Accounts / authentication
  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you.

Actions
Copy link
 #5

Updated by Marius BĂLTEANU about 4 years ago

Go Maeda, do you see any problem if we deliver this in 4.2.2? Being an improvement of a new feature of 4.2.0.

Actions
Copy link
 #6

Updated by Go MAEDA about 4 years ago

  • Status changed from Closed to Resolved
  • Target version changed from 5.0.0 to 4.2.2

Marius BALTEANU wrote:

Go Maeda, do you see any problem if we deliver this in 4.2.2? Being an improvement of a new feature of 4.2.0.

I didn't backport this fix to 4.2-stable because I thought very few people are currently bothered by the issue, but I think it is OK to include it in 4.2.2.

Actions
Copy link
 #7

Updated by Go MAEDA about 4 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF