Patch #35466

Rename test/fixtures/configuration/*.yml.example to test/fixtures/files/configuration/*.yml

Added by Go MAEDA about 1 month ago. Updated 22 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:5.0.0

Description

The test suite has some YAML files that are used by test/unit/lib/redmine/configuration_test.rb. And the YAML files have a file extension ".yml.example" instead of the standard ".yml". This is to prevent "rake db:fixtures:load" from failing (#30811). Files with a “.yml” extension placed under “text/fixtures” directory are treated as test fixtures and cause the failure.

In Rails 6.1.4, db:fixtures:load now ignores YAML files under text/fixtures/files (see https://github.com/rails/rails/pull/42153). This means that "*.yml" files will no longer cause db:fixtures:load to fail if they are placed in that directory and we can stop using an awkward ".yml.example" extension.

The attached patch moves the YAML files under /text/fixtures/files directory and changes the file extension back to ".yml".


Related issues

Related to Redmine - Defect #30811: "rake db:fixtures:load" does not work Closed
Related to Redmine - Feature #29914: Migrate to Rails 6.1 New

Associated revisions

Revision 21067
Added by Go MAEDA 22 days ago

Rename test/fixtures/configuration/*.yml.example to test/fixtures/files/configuration/*.yml (#35466).

History

#1 Updated by Go MAEDA about 1 month ago

  • Related to Defect #30811: "rake db:fixtures:load" does not work added

#2 Updated by Go MAEDA about 1 month ago

#3 Updated by Go MAEDA about 1 month ago

  • Target version set to 5.0.0

Setting the target version to 5.0.0.

#4 Updated by Go MAEDA 22 days ago

  • Subject changed from Use file_fixture to load YAML files in Redmine::ConfigurationTest to Rename test/fixtures/configuration/*.yml.example to test/fixtures/files/configuration/*.yml
  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch.

Also available in: Atom PDF