Project

General

Profile

Actions

Defect #35957

closed

MessagesControllerTest#test_post_new test fails (trunk)

Added by Mizuki ISHIKAWA over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Code cleanup/refactoring
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Failure:
MessagesControllerTest#test_post_new [/usr/src/redmine/test/functional/messages_controller_test.rb:163]:
Expected: ["jsmith@somenet.foo"]
  Actual: ["dlopper@somenet.foo"]

rails test test/functional/messages_controller_test.rb:131

There is no guarantee that the elements will be in the order of "first: author, second: member" in the array mails, so the test should be modified so that it does not depend on the order.

I've had the same problem before and fixed it(#34169), but the change in r21130 seems to have caused the problem again.


Files

fix-test.patch (715 Bytes) fix-test.patch Mizuki ISHIKAWA, 2021-10-06 10:16

Related issues

Related to Redmine - Feature #30820: Drop setting "Blind carbon copy recipients (bcc)"ClosedMarius BĂLTEANU

Actions
Actions #1

Updated by Mizuki ISHIKAWA over 2 years ago

A patch for the fix is attached.

Actions #2

Updated by Marius BĂLTEANU over 2 years ago

  • Status changed from New to Confirmed
  • Assignee set to Marius BĂLTEANU
Actions #3

Updated by Go MAEDA over 2 years ago

  • Description updated (diff)
Actions #4

Updated by Marius BĂLTEANU over 2 years ago

  • Status changed from Confirmed to Closed
  • Resolution set to Fixed

Committed, thanks!

Actions #5

Updated by Go MAEDA over 2 years ago

  • Related to Feature #30820: Drop setting "Blind carbon copy recipients (bcc)" added
Actions

Also available in: Atom PDF