Defect #36273

Modifying the source code of a plugin does not reload it after r21295

Added by Hirokazu Onozato about 1 year ago. Updated about 1 month ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Rails support
Target version:5.0.5
Resolution:Fixed Affected version:5.0.0

Description

It seems that modifying the source code of a plugin in development mode does not reload it anymore.

For example, if you change the following file

  • plugins/redmine_issue_assign_notice/lib/redmine_issue_assign_notice/notice_client.rb

In Redmine trunk r21295 does not reload.
In 4.2.2, it was reloaded.

If i change the source code of Redmine itself, it will be reloaded in trunk r21295 as well.

  • app/models/issue.rb

Has Zeitwerk support removed the Redmine plugin folder from monitoring?

0001-Add-the-code-under-lib-redmine-and-plugins-to-the-fi.patch Magnifier (1.22 KB) Takashi Kato, 2022-12-17 07:14


Related issues

Related to Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading Closed
Related to Redmine - Defect #36218: Plugin assets are not copied correctly in trunk r21289 Closed
Duplicated by Redmine - Defect #38021: Development mode, class-reloader is not work. Closed

Associated revisions

Revision 21992
Added by Go MAEDA about 1 month ago

Modifying the source code of a plugin does not reload it after r21295 ( #36273).

Patch by Takashi Kato.

Revision 21997
Added by Go MAEDA about 1 month ago

Merged r21992 from trunk to 5.0-stable (#36273).

History

#1 Updated by Takashi Kato about 1 month ago

After some research, I've found out that the directory settings monitored by Zeitwerk and monitored by the Reloader must be done respectively.
(In the code of Redmine itself, these settings done automatically by Rails.)

The attached patch will fix the problem(can be applied to r21991).

#2 Updated by Go MAEDA about 1 month ago

  • Related to Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading added

#3 Updated by Go MAEDA about 1 month ago

  • Related to Defect #36218: Plugin assets are not copied correctly in trunk r21289 added

#4 Updated by Go MAEDA about 1 month ago

  • Category set to Rails support
  • Status changed from New to Confirmed
  • Target version set to Candidate for next minor release

#5 Updated by Go MAEDA about 1 month ago

  • Subject changed from Modifying the source code of the plugin does not reload it in trunk 21295 to Modifying the source code of a plugin does not reload it after r21295
  • Target version changed from Candidate for next minor release to 5.0.5
  • Affected version set to 5.0.0

Setting the target version to 5.0.5.

#6 Updated by Go MAEDA about 1 month ago

  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix. Thank you.

#7 Updated by Go MAEDA about 1 month ago

  • Duplicated by Defect #38021: Development mode, class-reloader is not work. added

#8 Updated by Go MAEDA about 1 month ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF