Defect #36393
closed
Mailer.with_synched_deliveries doesn't correctly detect other async Queue adapters
0%
Description
Mailer.with_synched_deliveries source:/trunk/app/models/mailer.rb@21350#L639 will not detect other async queue adapters than the Rails core ActiveJob::QueueAdapters::AsyncAdapter (such as those used by external queuing systems such as the DelayedJobAdapter, ResqueAdapter or SidekiqAdapter).
With these queue adapters in normal use, Mailer.with_synched_deliveries does nothing. This can lead to problems as it is expected that email deliveries (in our case daily reminders) would run inline but instead they were attempted to be scheduled using the normal queue adapter.
Files
Related issues
Updated by Felix Schäfer over 2 years ago
- File 36393-synched_deliveries_always_inline.patch 36393-synched_deliveries_always_inline.patch added
The attached patch simply removes the check for the ActiveJob::QueueAdapters::AsyncAdapter. This ensures deliveries in this context are always inline without trying to be clever about it.
Updated by Holger Just over 2 years ago
- Description updated (diff)
- Status changed from New to Confirmed
Updated by Holger Just over 2 years ago
- Related to Defect #36395: Mailer.with_synched_deliveries is not thread-safe added
Updated by Go MAEDA over 2 years ago
- Target version set to 5.0.0
Setting the target version to 5.0.0.
Updated by Go MAEDA over 2 years ago
- Status changed from Confirmed to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you.