Feature #37119
Drop redcarpet dependency for common_mark formatter
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Marius BALTEANU | % Done: | 0% | |
| Category: | Code cleanup/refactoring | |||
| Target version: | 5.1.0 | |||
| Resolution: | Fixed |
Description
Redmine fails to start when it's installed without markdown group (#36892).
We should fix this and drop the redcarpet dependency for common_mark.
Associated revisions
Move methods related to wiki section to a helper file and include it in all 3 formatters (#37119).
Drop redcarpet dependency from common_mark group (#37119).
Fix rubocop warnings (#37119).
Add frozen_string_literal and copyright (#37119).
History
#1
Updated by Marius BALTEANU about 1 month ago
- Assignee set to Marius BALTEANU
#2
Updated by Marius BALTEANU about 1 month ago
- File 0001-Move-methods-related-to-section-to-a-helper-file-and.patch
added - File 0002-Drop-redcarpet-dependency-from-common_mark-group.patch added
@Holger, I made a patch that should fix this.
What I did?- I've moved the methods
get_section,update_sectionandextract_sectionsto a new helper file (Redmine::WikiFormatting::SectionHelper) - the new helper file is included by all three formatters
- textile formatter overrides
extract_sectionsmethod which his own implementation - I've removed the
redcarpetdependency fromcommon_markgroup.
What do you think?
#3
Updated by Holger Just 21 days ago
Looks good to me, tanks!
#4
Updated by Marius BALTEANU 21 days ago
- Status changed from New to Closed
- Resolution set to Fixed
Thanks Holger for your review. I've committed both changes.