Project

General

Profile

Actions

Feature #37119

closed

Drop redcarpet dependency for common_mark formatter

Added by Marius BĂLTEANU about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

Redmine fails to start when it's installed without markdown group (#36892).

We should fix this and drop the redcarpet dependency for common_mark.


Files


Related issues

Related to Redmine - Defect #36892: Redmine does not start when installed --without markdownClosedMarius BĂLTEANU

Actions
Actions #1

Updated by Marius BĂLTEANU about 2 years ago

  • Assignee set to Marius BĂLTEANU
Actions #2

Updated by Marius BĂLTEANU about 2 years ago

holger mareck, I made a patch that should fix this.

What I did?
  • I've moved the methods get_section, update_section and extract_sections to a new helper file (Redmine::WikiFormatting::SectionHelper)
  • the new helper file is included by all three formatters
  • textile formatter overrides extract_sections method which his own implementation
  • I've removed the redcarpet dependency from common_mark group.

What do you think?

Actions #3

Updated by Holger Just almost 2 years ago

Looks good to me, tanks!

Actions #4

Updated by Marius BĂLTEANU almost 2 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Thanks Holger for your review. I've committed both changes.

Actions #5

Updated by Holger Just about 1 year ago

  • Related to Defect #36892: Redmine does not start when installed --without markdown added
Actions

Also available in: Atom PDF