Feature #37119
closed
Drop redcarpet dependency for common_mark formatter
Added by Marius BĂLTEANU over 3 years ago.
Updated over 3 years ago.
Category:
Code cleanup/refactoring
Description
Redmine fails to start when it's installed without markdown group (#36892).
We should fix this and drop the redcarpet dependency for common_mark.
Files
- Assignee set to Marius BĂLTEANU
holger mareck, I made a patch that should fix this.
What I did?
- I've moved the methods
get_section, update_section and extract_sections to a new helper file (Redmine::WikiFormatting::SectionHelper)
- the new helper file is included by all three formatters
- textile formatter overrides
extract_sections method which his own implementation
- I've removed the
redcarpet dependency from common_mark group.
What do you think?
- Status changed from New to Closed
- Resolution set to Fixed
Thanks Holger for your review. I've committed both changes.
- Related to Defect #36892: Redmine does not start when installed --without markdown added
Also available in: Atom
PDF
Updated by 
Updated by